[Feat]: Support for devices whose MountAngle is not general about streampack HOT 7 OPEN

Hi there,

I have the feeling that there was on issue with the orientation, but it is a really painfull subject 🧠
Could you check that tapping on StreamPack Preview properly set the focus on the same place as the preview (with your patch).
Do you have in mind an easy way to test this?

Best regards,
Thibault

from streampack.

Hi
Thank you for taking this issue.

Just did the test with my webcam and sensor orientation is also 90 degrees...

I apologize that it did not behave as expected. I will conduct further investigation on my end as well.

From a technical point, I believe it is possible to build an emulator image with Angle other than 90 from AOSP. However, I consider that as a last resort..

from streampack.

As the preview and the stream are 2 different things, there might be 2 issues.
To display the preview on your device, what view do you use?

from streampack.

Hello.

The combination of device orientation and camera mount angle is a headache.

The patch I created focuses only on the stream.
The preview is not fixed and needs additional work. (sry...)
I will try more when I have time.

A simple test... This is also difficult.
Probably, you hard to get a reproducible device.
I think it would be better to do it on an android emulator, but i have to examine emulator's configuration.

from streampack.

Sorry I haven't had much time to do this....

I tried to build a simple environment.
It may be possible to build it with an "android emulator" and "external usb camera".

Some devices for auto (vehicles) like alps YT9213AJ support external usb camera and it returns 0 camera sensor orientation
android/camera-samples#361

The report says "YT9213AJ supports external usb camera and it returns 0 camera sensor orientation > ".

So,

• Connect an external usb camera (sensor orientation = 0) to the PC
• On the PC, specify the camera device when starting the emulator.
  e.g. emulator.exe -avd PixelC -camera-back webcam1.
  This may work.

However, I do not have an external usb camera at hand,
so I installed the virtual camera driver and confirmed that the emulator even uses the camera.
Unfortunately, the virtual camera driver recognized sensor orientation = 90, so it may not work.

Thank you.

from streampack.

Hi,
Sorry I missed you last messages.

The combination of device orientation and camera mount angle is a headache.

Agreed! It is not clear at all.

I will try to test with an android emulator and an external USB camera. Thanks for the information.

In the meantime, I reworked the management of the orientation. It is not going to fix your issue but it might be easier to debug.
Everything is in https://github.com/ThibaultBee/StreamPack/blob/5ae4592ecfe2e6f5ebcc1d49296bf5f1a068cbf0/core/src/main/java/io/github/thibaultbee/streampack/internal/sources/camera/CameraSource.kt#L130C14-L130C14
I guess your issue has a link with the default buffer size. But it is still unclear how to set setDefaultBufferSize.

from streampack.

I will try to test with an android emulator and an external USB camera. Thanks for the information.

Just did the test with my webcam and sensor orientation is also 90 degrees...
Looking for a way to test or for a clear explanation of https://developer.android.com/training/camera2/camera-preview

from streampack.