Comments (10)
I've just noticed that it does check for portrait landscape etc. but it doesn't work on the devices I've tested. Pixel 7, Pixel 6 Pro, ASUS ROG, So it always broadcasts in landscape.
The rotation degrees passed into isPortrait is always 0, regardless of the device orientation. I've tried manually returning 'true' and that does fix the output video size, but the actual video data inside is wrong size/maybe aspect so not sure where else to alter?
Is it possible to check whether we're in portrait/landscape by doing device portrait = width > height
Thank you.
from streampack.
Hi,
I am not sure to fully understand the whole issue. Could make screenshot of what the stream looks like and what you expect.
Could you also point where you have read rotation degrees?
There has been changed on the management on the orientation on the main
branch. Could you test it with the screenrecorder
sample?
from streampack.
Hi,
I've attached a screenshot from OBS receiving the SRT feed here: https://imgur.com/a/HhYi9dc - It shows the video being received in 1920x1080 with the phone centered and scaled in the middle. As I am in portrait mode, I was expecting to receive a portrait resolution of the phone. (Like this, https://imgur.com/a/Afmmw9e) as it does with Larix Screencaster and other screencasting apps.
This is from the main branch, screenrecorder demo from a couple of days ago. I will double check where I was reading the orientation as I know there were a few places, but isPortrait was always returning false as I recall.
Thanks
from streampack.
Instead of FixedOrientationProvider(orientation = 0)
, you could try to use DeviceOrientationProvider()
from streampack.
Hello,
Thank you - I can confirm that changing that has resized the output and I am receiving it in the correct size/orientation. However the image that is captured inside is not scaled properly - Image here: https://imgur.com/a/vovZArx
EDIT: I could be way off, but as its now a rotated resolution, could that problem in the image above be related to the FullFrameRect FULL_RECTANGLE_COORDS / FULL_RECTANGLE_TEX_COORDS as the positions would have changed?
Thanks
from streampack.
Hello,
Could you try to invert setDefaultBufferSize
in VideoMediaCodecEncoder
?
from streampack.
Hi,
Almost there! Inverting the values of setDefaultBufferSize() produced this, correct width, half height, with the bottom half cut off.
This was with: setDefaultBufferSize(minOf(height, width),maxOf(height, width))
from streampack.
Not sure if it's the right way to do it, but flipping the start resolution and adding an option of: Size(1080, 1920),
has done the trick! - Plus the two changes you mentioned above. Thank you!
from streampack.
Hi,
I reworked how the orientation works. Could you check screen recording in portraint in the main
branch?
from streampack.
Released in 2.6.0.
Please reopen the issue if it is not fixed.
from streampack.
Related Issues (20)
- [Bug]: MP4 File appears to have time duration 00:01 in video player HOT 4
- [Bug]: When the higher video bit rate is used for SRT streaming, the video will frequently appear green screen or mosaic HOT 4
- [Bug]: Error while starting demo screen streamer HOT 2
- Is it possible to use a dns to broadcast the streaming, say no-ip or others? HOT 2
- Connection Error HOT 2
- [Bug]: SrtProducer.connect(url) always throws "unknown host" when onConnectionListener is null HOT 2
- [Feat]: Get current bitrate of the stream HOT 3
- Video Capture Mirroring HOT 8
- [Feat]: Support for devices whose MountAngle is not general HOT 7
- [Feat]: Background RTMP Streaming HOT 4
- [Feat]: Add SRTLA (SRT transport proxy with link aggregation for connection bonding) HOT 1
- [Bug]: Streaming the SRT video has a lot of lag HOT 2
- [Bug]: App crashes with "eglMakeCurrent failed" error HOT 2
- [Bug]: app crashes when start running HOT 2
- [Feat]: High latency when using the RTMP HOT 2
- [Bug]: When using SRT to push 1080P video, the latency is severe, about 7 seconds! HOT 3
- [Bug]: There are severe mosaics at higher bit rates(>2Mb/s). HOT 5
- [Bug]: tap to focus while zoomed out causes crash HOT 7
- [Bug]: "demo-camera" app crashes at startup HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from streampack.