Git Product home page Git Product logo

Comments (10)

magnetophon avatar magnetophon commented on August 23, 2024 1

Cool!
A range from 0 to 1 for the steps master seems like it would get us 80% of the results for 20% of the effort (said the armchair quarterback).
So just go with that then?

from bschaffl.

sjaehn avatar sjaehn commented on August 23, 2024

Do you mean "dry/wet" sliders for MIDI ? With values which exceed the 0 (dry) to 1 (wet) limit ?

from bschaffl.

magnetophon avatar magnetophon commented on August 23, 2024

Yes. As a matter of fact, the first title I typed had "dry/wet" in it! :)

I though that would be a confusing way of saying it. 🤷

from bschaffl.

sjaehn avatar sjaehn commented on August 23, 2024

Added to TODO. I will call it "amp master" and "steps master" (already on GUI).

The amp master will be easy to make. Even with values > 1.0 and values < 0.0.

The steps/swing master will really be tricky. At least with values outside the 0.0 .. 1.0 range. Values > 1.0 (or values < 0.0) may result in invalid step positions (= overtaking the respective neighbor steps). This condition needs to be handled. Also the steps master will take effect on the plugin latency. And what will be the result if you make a change during playback?

from bschaffl.

sjaehn avatar sjaehn commented on August 23, 2024

I like the idea with values > 1.0 and values < 0.0 for the steps master too. But I'll start with 0.0 .. 1.0 range.

from bschaffl.

sjaehn avatar sjaehn commented on August 23, 2024

I though again about how to name this effect.

My idea to call it "master" is bad. What would you expect to hear if a master value is at 0 ? Nothing. But you get the unchanged input signal here.

"Amount" is not clear enough. This would need further explanations.

"Mix" is better. But still, further explanations are needed (mixing what?)

"Dry/wet" would theoretically be the best explanation. But I heard "dry/wet" only for audio signals before. Maybe I'm wrong.

Any (other) idea ?

from bschaffl.

magnetophon avatar magnetophon commented on August 23, 2024

I agree about master and amount.

To me, mix and dry/wet suggest you'll hear the mix of both signals, both the time-shifted and the original signal.
So IOW: I think those are confusing names too.

I think amount is the least bad, but we can come up with something better.

from bschaffl.

magnetophon avatar magnetophon commented on August 23, 2024

Strength?

from bschaffl.

sjaehn avatar sjaehn commented on August 23, 2024

You are right about mix and dry/wet.

"Amp process amount (or strength)* and "Step process amount (or strength)" would be better. But too long.

from bschaffl.

sjaehn avatar sjaehn commented on August 23, 2024

Sliders added in e6bcc76. I preliminarily used "Amp process" and "Step process". But I'm still open for any better idea.

from bschaffl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.