rtcamp / blank-theme Goto Github PK
View Code? Open in Web Editor NEWCustomized Blank theme based on Underscore and Foundation
Customized Blank theme based on Underscore and Foundation
Acceptance Criteria:
bin/init.js
The main class, the Blank_Theme
class should be in snake-case with capitalized letters since it's a class. It's BLANK_THEME
currently. The namespace also seems to have an incorrect value. Skim through the class names in the files and ensure classes and namespaces are named correctly.
Add theme.json file. Replace the theme supports which are now supported by the theme.json
file.
theme.json
file.Many themes use their own custom actions at the beginning of body tag to inject some script of Google AdSense or integrating Facebook pages Like scripts and so on.
Foundation Ticket: foundation/foundation-sites#12237
Ref: https://sass-lang.com/documentation/breaking-changes/slash-div
The wp-scripts has come a long way. Review the current build workflow and maybe update the npm scripts to use the scripts available in the 'wp-scripts' package.
The package comes with a few handy configurations for eslint and styling as well.
It's a nice build process you have but I am trying to understand why slick-carousel is in devDependencies and not in dependencies.
I am guessing this is a mistake or an edge case?
The package file needs to be updated to use the latest versions. It would be best if we could set up dependabot
for the repo.
When running npm run init
, though it does the renaming as expected however the script is written in a sloppy way
PHPCS error and warnings in inc/classes/class-base.php
Checked with WordPress
coding standard.
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------
50 | ERROR | Visibility must be declared on method "__destruct"
149 | WARNING | trigger_error() found. Debug code should not normally be used in production.
195 | WARNING | Method name "_add_hook" should not be prefixed with an underscore to indicate visibility
216 | WARNING | trigger_error() found. Debug code should not normally be used in production.
----------------------------------------------------------------------------------------------------------```
Currently, 'blank-theme' uses a custom autoloader, which works fine. However, to align the code more with how things are done for PHP in general, we can update to use the composer autoloader and remove the custom one.
Revisit the Singleton pattern used to compose and load the necessary components for the theme. Now, this may result in unnecessary classes being loaded on all requests. This may be fine with a small-scale code base; however, the complexity of features may add to memory cost. Identify/update to only load classes when needed.
Hello
I got some questions regarding the blank theme from the partner.
ack
through the codebase and finds where resources are registered, and I'm not sure I understand the advantage when it's only used three or four times.Thanks
CC: @chandrapatel
Based on best practices for the accessibility either remove the 'site-title' tag or update it.
The argument is that when we have title
tag and h1
for a page, what purpose does h2.site-title
serve?
Reference: https://github.com/rtCamp/blank-theme/blob/master/inc/helpers/template-tags.php#L124
Internal Comms: Slack Thread
When running npm run init
, I encountered an issue (check screenshot).
I tried using a previous version of node - v12.13.0 but still had the same issue.
Before that, I encountered this error - '.' is not recognized as an internal or external command
To solve that, I ran - npm config set script-shell bash
As advised on stackoverflow.
Once the search-replace is done, the user/developer has no idea of finding out where the theme originally originated from. If there were hints on the origin of the theme (blank theme), it would help somebody skimming through the codebase better understand architectural decisions and design patterns. We could get ahead and add some detail at the end of the readme file and in the header of the style.css
file, something the _s theme does.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.