Comments (9)
DevikVekariya
commented on August 18, 2024
@kiranpotphode please check the errors and let's add a GH action with phpcs checks here.
I'll help to add tokens to integrate the GH actions.
from blank-theme.
kiranpotphode
commented on August 18, 2024
@DevikVekariya Added PR for the GH action for PHPCS checks.
Please help with adding Secrets for the repo.
https://github.com/rtCamp/blank-theme/pull/34/files
from blank-theme.
DevikVekariya
commented on August 18, 2024
@kiranpotphode I just added the secrets VAULT_TOKEN and VAULT_ADDR to this repo
from blank-theme.
kiranpotphode
commented on August 18, 2024
Thanks @DevikVekariya
PHPCS action executed successfully.
You can approve and merge this PR #34.
Also #20 (comment)
File in which Errors are mentioned is no longer exist.
So you can merge the PR and close this issue.
from blank-theme.
DevikVekariya
commented on August 18, 2024
PR looks good to me #34
Can we test it with one phpcs error, please?
from blank-theme.
kiranpotphode
commented on August 18, 2024
Can we test it with one phpcs error, please?
I don't know if this will work unless code is merged in master or not. Can we merge PR in master first?
from blank-theme.
DevikVekariya
commented on August 18, 2024
Yeah, we can test it in that way. Approved the PR please go ahead to merge
from blank-theme.
kiranpotphode
commented on August 18, 2024
@DevikVekariya this is solved in #42
So we can close this issue.
from blank-theme.
DevikVekariya
commented on August 18, 2024
Yeah. Thanks @kiranpotphode
Closing this now.
from blank-theme.
Related Issues (17)
- [Question] Why is slick-carousel in devDependencies?
- Hide tagline from customizer is not working HOT 1
- Php Unit test case setup HOT 6
- Improve renaming script
- Accessibility: Site Title tag HOT 1
- Add wp_body_open action to inject script or action in beggining of body tag HOT 1
- Issue on Windows when I run `npm run init`
- CLI Scripts to auto format SCSS and JavaScript
- Issue with renaming script `npm run init`
- Update foundation version 6.7.* for Dart Sass compatibility HOT 1
- Update init script HOT 1
- Add pre-commit hook using husky
- QnA HOT 7
- Add theme.json file HOT 2
- Fix incorrect namespace and class name(s)
- Hint the origin of the theme
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blank-theme.