Summary

Once the search-replace is done, the user/developer has no idea of finding out where the theme originally originated from. If there were hints on the origin of the theme (blank theme), it would help somebody skimming through the codebase better understand architectural decisions and design patterns. We could get ahead and add some detail at the end of the readme file and in the header of the style.css file, something the _s theme does.

References

• style.css in _s
• #79 (comment)

It's a nice build process you have but I am trying to understand why slick-carousel is in devDependencies and not in dependencies.

I am guessing this is a mistake or an edge case?

PHPCS error and warnings in inc/classes/class-base.php

Checked with WordPress coding standard.

FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------
  50 | ERROR   | Visibility must be declared on method "__destruct"
 149 | WARNING | trigger_error() found. Debug code should not normally be used in production.
 195 | WARNING | Method name "_add_hook" should not be prefixed with an underscore to indicate visibility
 216 | WARNING | trigger_error() found. Debug code should not normally be used in production.
----------------------------------------------------------------------------------------------------------```

I tried to setup fresh theme and run init command to renaming and do cleanup.
after Renaming Successful message on terminal I checked package-name, text-domain, function prefix there is no change.

Node:  16.13.0
NPM: 8.1.0

Summary

Use the official wp-cli/i18n-command to generate POT file.

References

Acceptance Criteria

When running npm run init, I encountered an issue (check screenshot).
I tried using a previous version of node - v12.13.0 but still had the same issue.

Before that, I encountered this error - '.' is not recognized as an internal or external command
To solve that, I ran - npm config set script-shell bash
As advised on stackoverflow.

Currently, we only have scripts for linting scss and JavaScript, we need to add scripts to also auto-format them because we don't want to do that manually:

When running npm run init, though it does the renaming as expected however the script is written in a sloppy way

1. It does not handle errors.
2. It does not give enough information about the steps in progress.
3. Incorrect colors used for showing progress.
4. It should rename the theme folder name from blank-theme => chosen name or create a new copy of the renamed theme and keep blank-theme as it is.

Hello

I got some questions regarding the blank theme from the partner.

1. This theme seems to have been based on Underscores -- but the license in package.json was changed from GPL-2.0-or-later to MIT -- why was that change made?
2. Underscores also has a /style.css in the root directory of the theme that is built from the /sass/ folder in the theme. It looks like you've rearchitected the Sass to be be nested several directories down in the /assets/src/sass/ and output to the /assets/build/css/ folders, rather than the WordPress-standard /style.css file in the root. Why?
3. It seems the main.css and other generated css files are compressed at the highest degree, saving some bits of data with the tradeoff of maintenance and comprehension. Was this an intentional choice?
4. Why was the functions.php from underscores rewritten to a much more complex autoloader system?
5. Could you explain how you weighted the cost/benefit of building wrapper methods for WordPress core functionality such as registering styles? It feels like a needless bit of complexity that makes it more difficult to ack through the codebase and finds where resources are registered, and I'm not sure I understand the advantage when it's only used three or four times.
6. Is there a reason for the theme not including a theme.json file for the block editor to be able to use to guide font sizes, colors, and the like?
7. For how constants are named -- something ending in _TEMP_DIR feels confusing when it's used to refer to a "Template Directory" rather than a directory for temporary files -- minor stuff, but more of a remark that it may want to be reevaluated for naming patterns.

Thanks

CC: @chandrapatel

Summary

• Setup lint-satged and husky.

References

Acceptance Criteria

Many themes use their own custom actions at the beginning of body tag to inject some script of Google AdSense or integrating Facebook pages Like scripts and so on.

• So it would be helpful to add support for that. In WordPress 5.2 added support for this by wp_body_open hook.

• Create a setup for Php Unit Tests along with the documentation.

Acceptance Criteria:

• Each class and its method should pass though the Php Unit test case
• If any of the methods is ignored then, it should have proper docs with a reason to ignore it.
• It should have detailed documentation for the local setup of Unit tests and how to run it locally.

Based on best practices for the accessibility either remove the 'site-title' tag or update it.

The argument is that when we have title tag and h1 for a page, what purpose does h2.site-title serve?

• Present any technical research for backing your decision.

Reference: https://github.com/rtCamp/blank-theme/blob/master/inc/helpers/template-tags.php#L124

Internal Comms: Slack Thread

Summary

• Update theme init script in bin/init.js

References

Acceptance Criteria

Foundation Ticket: foundation/foundation-sites#12237

Ref: https://sass-lang.com/documentation/breaking-changes/slash-div

Summary

Add theme.json file. Replace the theme supports which are now supported by the theme.json file.

References

• theme.json official doc
• Cheat Sheet: Every setting that you can remove using theme.json
• Block theme generator

Acceptance Criteria

• Ensure all supported block supports and configuration has been moved from PHP code to the theme.json file.

Summary

The main class, the Blank_Theme class should be in snake-case with capitalized letters since it's a class. It's BLANK_THEME currently. The namespace also seems to have an incorrect value. Skim through the class names in the files and ensure classes and namespaces are named correctly.

References

• class-blank-theme.php file
• WordPress Naming Convention
• #79 (comment)