Git Product home page Git Product logo

Comments (6)

max-sixty avatar max-sixty commented on May 14, 2024

Yes good idea.

I've had lots of success with pre-commit, so if there are hooks for rustfmt on that, then that could work. It has a nice feature that it'll auto-fix PRs, and can be run locally: https://pre-commit.com/#pre-commitci-example. Here's the config we use in xarray: https://github.com/pydata/xarray/blob/main/.pre-commit-config.yaml

That GHA looks good too β€”Β fine to start with that!

from prql.

max-sixty avatar max-sixty commented on May 14, 2024

Another thing we could run (maybe every day rather than on PRs) is cargo audit

from prql.

max-sixty avatar max-sixty commented on May 14, 2024

We have a decent set of checks now, including rustfmt, and I just added pre-commit. If anyone is up for making a contribution here, things we could add:

Or any others β€” I'm always up for automating as much as possible.

from prql.

max-sixty avatar max-sixty commented on May 14, 2024

https://gist.github.com/PurpleBooth/84b3d7d6669f77d5a53801a258ed269a has some great examples

from prql.

max-sixty avatar max-sixty commented on May 14, 2024

https://github.com/max-sixty/prql/pull/289 now runs tests on all platforms on merge (or a specific PR label), and splits the tests up such that they complete in 32s

from prql.

max-sixty avatar max-sixty commented on May 14, 2024

These are all done! Closing

from prql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.