Nightly tests failed on

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

This seems due to the rust toolchain version. <a href="https://githu

This seems due to the rust toolchain version. <p dir="a

<a class="user-mention notranslate" data-hovercard-type="user" data-hover

Nightly tests failed about prql HOT 4 CLOSED

github-actions commented on May 27, 2024

Nightly tests failed

from prql.

Comments (4)

eitsupi commented on May 27, 2024 1

@max-sixty I don't think the following jobs have been executed for the past few months.
We needed to rewrite the if condition, but it looks like we didn't do that. Can you see what's happening?

prql/.github/workflows/nightly.yaml

Lines 23 to 25 in 9338413

 if: 

 ${{ !github.event.pull_request.head.repo.fork && !github.actor == 

 'dependabot[bot]' }}

from prql.

eitsupi commented on May 27, 2024

This seems due to the rust toolchain version.

https://github.com/PRQL/prql/actions/runs/7346895859/job/20002422523#step:3:222

  Caused by:
    package `cargo-release v0.25.1` cannot be built because it requires rustc 1.73 or newer, while the currently active rustc version is 1.72.0

prql/rust-toolchain.toml

Line 4 in 9338413

channel = "1.72.0"

from prql.

max-sixty commented on May 27, 2024

This seems due to the rust toolchain version.

#4016

from prql.

max-sixty commented on May 27, 2024

@max-sixty I don't think the following jobs have been executed for the past few months.
We needed to rewrite the if condition, but it looks like we didn't do that. Can you see what's happening?

You're completely right.

What's odd is that some do work:

prql/.github/workflows/pull-request-target.yaml

Line 78 in 9af8e7f

if: ${{ !github.event.pull_request.head.repo.fork }}

I put #4018 in to try and address it

from prql.

Recommend Projects