Incorrect Postgres interval syntax about prql HOT 4 CLOSED

Nice find!

I think GlareDB will follow the Postgres spec.

(We disabled their tests recently since there were some inconsistencies in a new version — I think we shouldn't prioritize GlareDB highly relative to Postgres...)

from prql.

Since GlareDB (i.e., DataFusion behind it) copies Postgres syntax, it simply copied Postgres' when implementing the GlareDB dialect. In other words it was not set up to match GlareDB, it was there originally.

from prql.

Thanks @MaksimMisin

(@m-span this is an example of a small SQL gen issue. Those will persist through any changes to the resolver. While this isn't exactly a foundational issue, it would be a nice intro to that end of the compiler...)

from prql.

After a little exploring, I found the relevant lines of code

sql/gen_expr.rs::395-399:

            let value = if ctx.dialect.requires_quotes_intervals() {
                Box::new(sql_ast::Expr::Value(Value::SingleQuotedString(vau.n.to_string())))
            } else {
                Box::new(translate_literal(Literal::Integer(vau.n), ctx)?)
            };

It appears that this exception to use quotes on the value 2 in '2' WEEK is only done for postgres and glaredb.

Interestingly enough, while I do see that Postgres documentation states that it requires special quoting as described by the OP, I can't find anywhere in the GlareDb documentation where it requires the value to be quoted by itself. Certainly no other databases require this, to my knowledge. The documentation is quite sparse on this topic @max-sixty Is this actually the desired behavior for GlareDb? If so, should it also be adjusted to meet the postgres spec?

This is a weird spec, to fail on WEEK but not DAY

from prql.