Comments (2)
The main thing I think we could improve is the display of errors in the playground that don't have spans.
For example, in "Input contains only a comment", we could still show the red box that we normally show with the error message at the bottom. That could be a nice PR on the playground
I'm open to other ways in the UI of showing the query isn't current, but we do want to retain a view of the most recently valid query, otherwise typing a query is going to be like being in an arcade game, as the query flashes between being valid and invalid.
Panics could also be formatted like this, but also we should just try and never panic (current discussion at #4037 (comment))
(There's a question of whether an empty query should be an error, I'm not sure, plausibly it should be OK but no strong view)
I don't see anything wrong about the prqlc CLI exit codes, is there? All the errors return an exit code of 1.
from prql.
These are all good points. I don't have any specific recommendations, I simply wanted to document all that I found when horsing around. I'll close this for now.
from prql.
Related Issues (20)
- Nightly tests failed HOT 1
- Some aggregation functions need ORDER BY clause
- Unexpected result with s-string including UNNEST HOT 1
- Nightly tests failed HOT 1
- Nightly tests failed HOT 1
- RUSTSEC-2024-0336: `rustls::ConnectionCommon::complete_io` could fall into an infinite loop based on network input HOT 1
- Nightly tests failed
- Nightly tests failed
- Nightly tests failed
- Compiler crash on `from_text` with zero rows HOT 4
- unexpected error on non-prql file HOT 1
- Add sampling extension support to PRQL HOT 3
- DISTINCT ON does not ensure columns exist
- [Docker] the 'cargo' binary ... is not applicable to the '1.77.2-aarch64-unknown-linux-gnu' toolchain HOT 3
- Arrow type system as base for the type system HOT 1
- 'std' panics on lowering HOT 2
- Dev Container: can't run playground or book (can run website) HOT 19
- Incorrect Postgres interval syntax HOT 1
- Query optimization: join prunning and "uniqeness" HOT 3
- std.in operator does not support expression on left-hand-side HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prql.