Git Product home page Git Product logo

Comments (2)

max-sixty avatar max-sixty commented on May 23, 2024

The main thing I think we could improve is the display of errors in the playground that don't have spans.

For example, in "Input contains only a comment", we could still show the red box that we normally show with the error message at the bottom. That could be a nice PR on the playground


I'm open to other ways in the UI of showing the query isn't current, but we do want to retain a view of the most recently valid query, otherwise typing a query is going to be like being in an arcade game, as the query flashes between being valid and invalid.


Panics could also be formatted like this, but also we should just try and never panic (current discussion at #4037 (comment))


(There's a question of whether an empty query should be an error, I'm not sure, plausibly it should be OK but no strong view)


I don't see anything wrong about the prqlc CLI exit codes, is there? All the errors return an exit code of 1.

from prql.

richb-hanover avatar richb-hanover commented on May 23, 2024

These are all good points. I don't have any specific recommendations, I simply wanted to document all that I found when horsing around. I'll close this for now.

from prql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.