Comments (4)
Thanks for looking into this. When you feel ready, submit it as a PR and I'll give it a review! :)
Edit: I find it easier to review as a change-set rather than browse through the source files.
from e.deezer.
@projectgoav Maybe we can create new deezer account for unit test purpose? I thing that would be easy way to cover all methods with tests...
from e.deezer.
I did some work a long time ago on mocking out the API to return fake data but never continued. Working working on some UI as a sample use of the library so might continue this once that's complete.
Performing tests against the real API is difficult as without logging in the calls are rate limited and the test would probably hit this value very quickly. There's no easy way to automate authentication on the public API Deezer provide
from e.deezer.
Hi!
I would like to help so I started to work on this issue. You can find my progress here (I will merge a few commits together after I finished):
https://github.com/PoLaKoSz/E.Deezer/tree/develop/clean-code
Can You give me some feedback about this solution?
Thank You!
πNotes:
- Found 2 bug while I wrote a few tests (this are the failing Unit tests)
- Coverage changed (41.04% -> 48.05%)
- Implemented a new approach which hopefully make the development and the testing more easy (mocking the server response)
from e.deezer.
Related Issues (20)
- Query if Favourited
- The UserEndpoint doesn't work well. HOT 6
- Unfortunately, it still does not work for me. :-(
- Convert project to target .net standard HOT 5
- Get playlist, artist, track and user by id HOT 7
- Stuck at getPlaylistById HOT 5
- Missing API errors / Exceptions mapped
- Radio -> `GetByGenre` invalid format HOT 1
- Negative GenreId can throw exception HOT 1
- Refactoring HOT 4
- Getting this error when im searching album name HOT 3
- Error when create new playlist HOT 2
- Comment listing without API key returns less data
- TimeAdd is processed wrong way HOT 4
- Release date return all time same value HOT 1
- track RealeaseDate HOT 5
- User/Playlists mixed response
- Getting the last track HOT 6
- DeezerSession does not have a "CreateNew()" method HOT 2
- playlist id longer than uint HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from e.deezer.