projectgoav / e.deezer Goto Github PK

Improve the performance of charts (reducing from 4calls to 1)
Improve the performance of tracklists (parse when returning from album)

API options for global params

Problem is when I using this lib in .NET core app I get build warning, and also I'm not sure it willl work on all platforms and OS.
So I thing the best way is to convert PCL project to .NET standard. In meantime, I forked repository and tried build with version 1.1 and everything is working fine.

.NET framewrok 4.5 also support .net standard 1.1
More details are here
https://docs.microsoft.com/en-us/dotnet/standard/net-standard

So, is it OK if you accept my changes and publish package to nuget?

Thank you!

Br,
Filip Kristo

Hi,

the getting data wiki says "var book = result.Result.Data;" but it leads to the following error:

"CS1061 'IBook' does not contain a definition for 'Data' and no extension method 'Data' accepting a first argument of type 'IBook' could be found (are you missing a using directive or an assembly reference?) "

• Image format has changed slightly (GetCover is obsolete)
• User now has an image

Allow in-lib authentication of users.

Deezer deezer = DeezerSession.CreateNew();
if (!deezer.IsAuthenticated) {
      await deezer.Login(access_token);
}
IUser user = deezer.Browse.CurrentUser.User;

The user object is empty. The iClient Object is null.

IEnumerable tracks = await user.First().GetFavouriteTracks();
gets an exception:

NullReferenceException: Object reference not set to an instance of an object.
E.Deezer.Api.User.Get<TSource, TDest>(string aMethod, DeezerPermissions aPermisisons, uint aStart, uint aCount) in User.cs
+
            if (!Client.IsAuthenticated)

I didn't see API methods for getting above resources by id.
Is there any of that? If not I can implement that?

Add user protection if network calls fail or timeout

The login throws OAuthException
You don't not have permission to access this information on Deezer. Deezer responded with result 200 - OAuthException'
You didn't pass the params by the login. Look at the line 220

Originally posted by @tolbxela in #58 (comment)

Wrapping around the Deezer Javascript SDK with an invisible webbrowser control may allow OAuth and Player functions in a C# application.
Communication C# -> JS and Js -> C# is possible which would make auto authentication easier and perhaps support playing functions via the JS functions.

Improve the internal structure to make it easier to understand. As highlighted by #17

• Albums (#45)
• Artists (#45)
• Playlists (#45)
• Tracks (#43)

HasPicture returns the inverse value

• Description

• Collaborative

• Unseen Track Count

• Fans

• ShareLink

• Checksum

• /seen

• /comments

• /fans

Tasks are no longer linked to the single cancellation token.

Exceptions fail to bubble up through tasks within E.Deezer and so the end-user is given "TaskCancelledException" without the proper information on why it failed.

Method + Class documentation improvements. Perhaps show how methods map to Deezer API responses. As highlighted by #17

• /Podcasts
• /Radios

Wiki docs are confusing and a little misleading. As highlighted by #17

Properties:

• Short title
• Title Version
• ISRC
• ShareLink
• Position
• Rank
• bpm
• gain
• available countries
• Alternative
• Contributors

Will there be an compiled version? (.exe)?

Thx :). Can't wait to check your project out ;)

• ShareLink

• Album Count

• Fan Count

• SmartRadio

• /Radio

Client is disposable, to ensure any active tasks are cancelled on exit ( #24 ) but is wrapped in non-disposable containers

Make pages easily browsable via their associated methods

• UPC
• ShareLink
• Genre
• Duration
• Fans
• Type
• Availability
• Explicit Lyrics
• Contributors
• IsFavourited()

Hi @projectgoav
Your nuget package has a invalid projectUrl which cause a error in VS 2015. Error: [nuget.org] Error converting value "http:///github.com/projectgoav/E.Deezer" to type 'System.Uri'. Path 'projectUrl', line 1, position 531.

You have 3 '/' after http:

Hope you will fix it asap.

--
Rasmus

Exceptions are unable to be handled correctly when using a method from the User endpoint/Iuser object.

Important since these give status on permissions and the access token provided.

Ensure V2 is correct before offical release.