Comments (5)
.NET Standard has been something I want to do for a while, just never got around to it! Happy to look at your changes and get them merged
from e.deezer.
Great! It will be soon.
Also, there is some build errors on unit test. IDeezerClient
is internal interfaces, so unit test cant see them.
Do you have any idea how to fix that?
If you want I can fix that or just ignore it?
from e.deezer.
You'll need to ensure that s NET Standard project doesn't automagically generate the AssemblyInfo. There's an xml element you add to the csproj for this which I can't remember off-hand.
If you can re-use the existing assemblyinfo.cs file then it should just work again. Otherwise you'll need to create a new one and add the [assembly: InternalsVisibleTo(<Assembly Name>)]
attribute for this to work :)
Edit: I'm happy for you just to ignore it. The tests don't really cover much (which I'd like to change) and may come out in the wash with future plans.
from e.deezer.
Because in .NET standard there is no AssembleyInfo.cs InternalsVisibleTo(<Assembly Name>)
attribute can add in any file... Here is a post about that...
http://anthonygiretti.com/2018/06/27/how-to-unit-test-internal-classes-in-net-core-applications/
Also, now there is no need for E.Deezer.nuspec
, because it can be defined in project settings, and nuget can generate on build. The result is E.Deezer.3.X.X.nupkg
in Release/Debug folder...
Here is a example
Also, because of ProjectReferences, it can automatically detect other nuget dependencies
from e.deezer.
Implemented in #66
from e.deezer.
Related Issues (20)
- Query if Favourited
- The UserEndpoint doesn't work well. HOT 6
- Unfortunately, it still does not work for me. :-(
- Get playlist, artist, track and user by id HOT 7
- Stuck at getPlaylistById HOT 5
- Missing API errors / Exceptions mapped
- Radio -> `GetByGenre` invalid format HOT 1
- Negative GenreId can throw exception HOT 1
- Refactoring HOT 4
- Getting this error when im searching album name HOT 3
- Error when create new playlist HOT 2
- Comment listing without API key returns less data
- TimeAdd is processed wrong way HOT 4
- Release date return all time same value HOT 1
- track RealeaseDate HOT 5
- User/Playlists mixed response
- Getting the last track HOT 6
- DeezerSession does not have a "CreateNew()" method HOT 2
- playlist id longer than uint HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from e.deezer.