I saw the new 5.X milest

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Refactoring about e.deezer HOT 4 CLOSED

PoLaKoSz commented on July 24, 2024

Refactoring

from e.deezer.

Comments (4)

projectgoav commented on July 24, 2024

Yep, agree with a lot of these points.

Use .NET built-in HTTP compression

What do you mean by this? Some implementations of HttpMessageHandler support compression automatically which is used. If the given MessageHandler implementation doesn't, we fallback to providing it ourselves.

Add server-side Exception checking to all (GET, POST, DELETE) requests

What are you proposing here?

Remove internal interfaces which has only one implementation

I think only API objects are exposed have public interfaces. I'll need to review this a bit more.

from e.deezer.

PoLaKoSz commented on July 24, 2024

Use .NET built-in HTTP compression

Sorry, probably i wasn't completly clear. I found this SO answer to signal the server that this wrapper can understand gzip, deflate response.
Relevant code:

E.Deezer/E.Deezer/ExecutorService.cs

Lines 176 to 177 in b2de544

 httpClient.DefaultRequestHeaders.AcceptEncoding.Add(new StringWithQualityHeaderValue("gzip")); 

 httpClient.DefaultRequestHeaders.AcceptEncoding.Add(new StringWithQualityHeaderValue("deflate"));

and

E.Deezer/E.Deezer/ExecutorService.cs

Lines 196 to 219 in b2de544

 private Stream GetDecompessionStreamForResponse(Stream responseStream, HttpContentHeaders contentHeaders) 

 { 

 // If header is not present the Deezer may not support this compression algorithm OR the 

 // given HttpMessageHandler has support for automatic compression. 

 if (contentHeaders != null && contentHeaders.ContentEncoding.Any()) 

 { 

 foreach (var entry in contentHeaders.ContentEncoding) 

 { 

 switch (entry.ToLowerInvariant()) 

 { 

 case "gzip": 

 { 

 return new GZipStream(responseStream, CompressionMode.Decompress); 

 } 

 case "deflate": 

 { 

 return new DeflateStream(responseStream, CompressionMode.Decompress); 

 } 

 } 

 } 

 } 

 return responseStream; 

 }

Add server-side Exception checking to all (GET, POST, DELETE) requests

For example the

E.Deezer/E.Deezer/DeezerClient.cs

Line 144 in b2de544

 public Task<T> GetPlain<T>(string method, IList<IRequestParameter> parms = null) 

method only checks (if i remember correctly) for HTTP status errors, and not inside the json response which could contain the error property. Yes, there is the GetPlainWithError method but probably this is a bit redundant in my opinion because i would probably check every server json response for any Exception.

Remove internal interfaces which has only one implementation

For example the IDeezerClient is an internal interface.

from e.deezer.

projectgoav commented on July 24, 2024

WRT your first point: The library allows you to pass an instance of the MessageHandler. if you are writing a Xamarin app for example, you can pass in the native NSUrlSessionHandler on Mac and iOS which allows you take advantage of the features of that platform. Each handler works differently and the default way works by stripping the content type headers if the handler has handled the compression.

It tries to let .NET do as much as possible before falling back to the library handling the decompression.

Add server-side Exception checking to all (GET, POST, DELETE) requests

This really should be done! :)

from e.deezer.

PoLaKoSz commented on July 24, 2024

@projectgoav i am finished with the refactoring.

from e.deezer.

Refactoring about e.deezer HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	httpClient.DefaultRequestHeaders.AcceptEncoding.Add(new StringWithQualityHeaderValue("gzip"));
	httpClient.DefaultRequestHeaders.AcceptEncoding.Add(new StringWithQualityHeaderValue("deflate"));

	private Stream GetDecompessionStreamForResponse(Stream responseStream, HttpContentHeaders contentHeaders)
	{
	// If header is not present the Deezer may not support this compression algorithm OR the
	// given HttpMessageHandler has support for automatic compression.
	if (contentHeaders != null && contentHeaders.ContentEncoding.Any())
	{
	foreach (var entry in contentHeaders.ContentEncoding)
	{
	switch (entry.ToLowerInvariant())
	{
	case "gzip":
	{
	return new GZipStream(responseStream, CompressionMode.Decompress);
	}
	case "deflate":
	{
	return new DeflateStream(responseStream, CompressionMode.Decompress);
	}
	}
	}
	}

	return responseStream;
	}