Git Product home page Git Product logo

Comments (5)

MiloszKrajewski avatar MiloszKrajewski commented on August 15, 2024

I see nothing suspicious (apart from allocating buffer all the time). This is just a read part. Can you attach project which does both - writes data and reads data?

from k4os.compression.lz4.

nexrom88 avatar nexrom88 commented on August 15, 2024

I think I found the problem.
I assumed that diffStream.Read(buffer, 0, buffer.Length); always reads "buffer.length" bytes from the stream. I found out that LZ4DecoderStream sometimes reads less bytes.

from k4os.compression.lz4.

UpUpLiu avatar UpUpLiu commented on August 15, 2024

i have this problem too
i think you need give some info for this api to let other know this rule.

from k4os.compression.lz4.

nexrom88 avatar nexrom88 commented on August 15, 2024

I think the problem is that DecoderStream buffers its decoded data internal within a 65536 bytes buffer. User first has to read all these bytes before this buffer gets filled again. That's when DecoderStream returns less bytes than needed.
I also think that this fact should get mentioned somewhere in the description of the API.

from k4os.compression.lz4.

MiloszKrajewski avatar MiloszKrajewski commented on August 15, 2024

Well, it is documented in Stream API:
https://docs.microsoft.com/en-us/dotnet/api/system.io.stream.read?view=netframework-4.8

Returns
Int32
The total number of bytes read into the buffer. This can be less than the number of bytes requested if that many bytes are not currently available, or zero (0) if the end of the stream has been reached.

from k4os.compression.lz4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.