Comments (5)
More specifically - if I use Extra Memory, it throws InvalidDataException "LZ4 frame magic number expected", and if I dont use extra memory, I get EndOfStreamException.
from k4os.compression.lz4.
Definitely looks like a bug. I'll take a look.
from k4os.compression.lz4.
You are right this is the behaviour. Last read DOES return 0 bytes, but if you try again it will throw.
There is one problem though.
I actually wanted it work that way, to allow appending to possibly finished stream.
Let's imagine that you have regular stream and you closed it, reopened it and started appending. It would form one contiguous stream of bytes.
With LZ4 stream I wanted it to be the same way. So, when you finish writing (and EoS marker is saved), you may start appending new stream. When reading, after end of stream, if you keep reading it just expects new stream to start (LZ4 magic number).
I guess it wasn't really thought through and no one was really asking for it.
I guess this is not as serious as I thought though because it does return 0 first time you encounter end of stream.
from k4os.compression.lz4.
Thanks Milosz - I'll take a closer look again - I didn't realize the first time returned zero successfully. On an unrelated note - do you have any interest in making a C# Zstd library? Current wrappers lack true .net standard suppport, and what you've done for LZ4 has been incredible!
from k4os.compression.lz4.
Fixed in 1.1.7
from k4os.compression.lz4.
Related Issues (20)
- Unity Support HOT 3
- Implicit reference to System.Runtime.CompilerServices.Unsafe appears to cause wrong version to be selected HOT 3
- Chained encoder does not produce the same result as the lz4 cli when chaining is enabled HOT 4
- Migrating from L4zNet to new implementation
- InvalidDataException: LZ4 frame magic number expected HOT 10
- Implement frame format with K4os.Compression.LZ4 HOT 2
- Question about random access, i want to make something similar to the original dictionaryRandoimAccess.c example HOT 5
- why Length return 7 HOT 1
- Question regarding Lz4net archived repo HOT 6
- LZ4 Legacy format support HOT 2
- LZ4EncoderStream Dispose Issue HOT 3
- Compression Issue? HOT 3
- API: LZ4Codec.Decode/Encode(Stream input, Stream output) HOT 12
- LZ4 with Maui HOT 7
- Stream API CopyTo got NotSupportedException HOT 4
- LZ4DecoderStream ReadAsync calls original stream's sync Read internally HOT 2
- [Question] Block vs Stream vs Pickler to store compressed bitmaps in memory HOT 10
- Adding non compressed data at the end of the stream HOT 2
- The `int LZ4Frame#Encode` overloads don't close the frame HOT 2
- The repository contains the code with the incompatible licenses HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from k4os.compression.lz4.