End of Stream Behavior about k4os.compression.lz4 HOT 5 CLOSED

More specifically - if I use Extra Memory, it throws InvalidDataException "LZ4 frame magic number expected", and if I dont use extra memory, I get EndOfStreamException.

from k4os.compression.lz4.

Definitely looks like a bug. I'll take a look.

from k4os.compression.lz4.

You are right this is the behaviour. Last read DOES return 0 bytes, but if you try again it will throw.

There is one problem though.
I actually wanted it work that way, to allow appending to possibly finished stream.
Let's imagine that you have regular stream and you closed it, reopened it and started appending. It would form one contiguous stream of bytes.
With LZ4 stream I wanted it to be the same way. So, when you finish writing (and EoS marker is saved), you may start appending new stream. When reading, after end of stream, if you keep reading it just expects new stream to start (LZ4 magic number).

I guess it wasn't really thought through and no one was really asking for it.

I guess this is not as serious as I thought though because it does return 0 first time you encounter end of stream.

from k4os.compression.lz4.

Thanks Milosz - I'll take a closer look again - I didn't realize the first time returned zero successfully. On an unrelated note - do you have any interest in making a C# Zstd library? Current wrappers lack true .net standard suppport, and what you've done for LZ4 has been incredible!

from k4os.compression.lz4.

Fixed in 1.1.7

from k4os.compression.lz4.