Git Product home page Git Product logo

Comments (5)

matsen avatar matsen commented on June 17, 2024

Renaming to "scaler" to correspond with libpll.

from linearham.

matsen avatar matsen commented on June 17, 2024

Also, no need to have scalers in germline.

from linearham.

matsen avatar matsen commented on June 17, 2024

Given that we may be looking at zero likelihoods from dummy paths, it seems to me that we should have an assertion in the rescaling code that keeps us from getting an infinite loop in the case of exactly zero likelihood.

from linearham.

dunleavy005 avatar dunleavy005 commented on June 17, 2024

Since the 0's will be within matrices that have non-zero values, I don't see how the infinite loop happens. Right now, the SCALE_FACTOR only multiplies if all entries of the matrix are less than SCALE_THRESHOLD, and since our matrices are mixed, we don't ever have a matrix just with 0's so it will stop at some point?

from linearham.

matsen avatar matsen commented on June 17, 2024

Would still be good to have an assertion that matrices aren't all zero.

from linearham.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.