Git Product home page Git Product logo

Comments (6)

dunleavy005 avatar dunleavy005 commented on June 22, 2024

My guess (without knowing anything about the family) is that the ASR is more uncertain due to the data loss and is just confused about substitution order. Looking at the image, I do see a somewhat certain path, does that path exist in the larger family graph too?

from linearham.

psathyrella avatar psathyrella commented on June 22, 2024

hmm, that sounds promising. @mmshipley does it seem possible that the main results are pretty much the same, there's just more low probability cruft? Maybe we can solve this as more a visualization problem, maybe don't display nodes below a certain probability (well i'm assuming that's what the filtering settings do, in which case I guess I'm suggesting maybe we can make the filtering settings smarter?).

from linearham.

psathyrella avatar psathyrella commented on June 22, 2024

She says yes, it seems likely that the main results end up the same. But I think it's still a real problem if it's easy to get diagrams like that ^ out, since most people will probably have the same response and ignore it and/or assume something's wrong (as happened here) so probably worth working on the filtering settings.

from linearham.

dunleavy005 avatar dunleavy005 commented on June 22, 2024

Yes, that makes sense, the filtering settings aren't perfect. FYI, I basically filter on edge probabilities (i.e. keep all edges if prob >= CUTOFF), maybe adding some node logic might improve it

from linearham.

psathyrella avatar psathyrella commented on June 22, 2024

Great. And thanks again for responding promptly, this is really helpful. It looks like jared will work on this in a month or so.

from linearham.

psathyrella avatar psathyrella commented on June 22, 2024

It seems like a better title for this at this point would be "fiddle with threshold settings for lineage path plotting", which is maybe worth doing, but without a working example that does something we don't like, I don't think there's any point in keeping this issue open.

from linearham.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.