Comments (5)
This caused all our LDK nodes who had channels with our LSP (which runs LND) to be force closed. This is a catastrophic bug, I hope a fix is prioritized.
2024-05-10 18:38:55 ERROR [lightning::ln::channelmanager:7150] Closing channel 04259a5524219241061608caa6216811cfcfcf713291fc3c839dde1d47a90a72 due to close-required error: Peer's feerate much too low. Actual: 253. Our expected lower limit: 2993
2024-05-10 18:38:55 ERROR [lightning::ln::channelmanager:8971] Force-closing channel: Peer's feerate much too low. Actual: 253. Our expected lower limit: 2993
2024-05-10 18:38:55 DEBUG [lightning::ln::channelmanager:2893] Finishing closure of channel due to Channel closed because of an exception: Peer's feerate much too low. Actual: 253. Our expected lower limit: 2993 with 0 HTLCs to fail
2024-05-10 18:38:55 INFO [lightning::chain::channelmonitor:2796] Applying force close update to monitor 04259a5524219241061608caa6216811cfcfcf713291fc3c839dde1d47a90a72 with 1 change(s).
from lnd.
I think we should return the error here to be handled by the callers instead of returning the fee floor,
lnd/lnwallet/chainfee/estimator.go
Lines 778 to 790 in 2089a88
Looking at other implementations of EstimateFeePerKW
, think we should do the same - upper systems need to know there's an error in fee estimation instead of defaulting to the default fee rate floor.
from lnd.
We should also smooth/clamp the updates as well. This way we avoid adjusting too sharply in either direction.
from lnd.
We should also smooth/clamp the updates as well. This way we avoid adjusting too sharply in either direction.
I wonder what's the best strategy to clamp the fee-rate, percentage of the current feerate seems to be not the best design when values are small hmm ?
Moreover maybe we should unify the behaviour for example for the bitcoind estimator we will return the fallback fee in case there is an error while fetching the data.
As @yyforyongyu said, best thing in case of error is to accept what the other party suggests. And in case the other party doesn't provide any value, just use the latest ones retrived.
In case of sudden change but no error, yes, it is probably better to clamp it over the course of, for example, 6 blocks.
For any of the two cases, you would need to store the information of the latest feeurl retrived, probably in a small separate file.
You would also need to return an error if too much time has passed since the last retrival happened. Again, I would suggest returning an error after 6 blocks without retriving anything. Also an error should be provided just at the beginning, exiting the app, if the first retrival fails and the file with the stored values does not exist or is too old.
from lnd.
We should also smooth/clamp the updates as well. This way we avoid adjusting too sharply in either direction.
I wonder what's the best strategy to clamp the fee-rate, percentage of the current feerate seems to be not the best design when values are small hmm ?
Moreover maybe we should unify the behaviour for example for the bitcoind estimator we will return the fallback fee in case there is an error while fetching the data.
from lnd.
Related Issues (20)
- [bug]: lncli openchannel breaking change - fee preference HOT 2
- NewAddress returns duplicate addresses HOT 4
- [feature]: unify address creation behavior between `BtcWalletKeyRing.DeriveNextKey` and `BtcWalletKeyRing.DeriveKey`
- [bug]: I'm completely unable to be synced with the Lightning network. HOT 2
- [bug]: Cannot send coins with 1 sat/vB HOT 6
- [bug]: Creating a new channel
- [bug]: Regression: Missing newline in "Shutdown complete" log message HOT 11
- [bug]: sweep: data race on TxPublisher.currentHeight HOT 2
- [bug]: `ChannelRouter` cannot be shutdown while the `syncGraphWithChain` function is running. HOT 4
- [bug]: Inbound fees are not in the gossip message when using `subscribeChannelGraph` HOT 2
- [bug]: Ping time is not accurate HOT 1
- [feature]: lncli command for walletrpc.EstimateFee HOT 4
- [bug]: Unable to pay AMP invoice with `amp` flag set to true
- Add new RPCs to control the fee bumping process
- [bug]: sweep: BumpFee can cause transaction conflicts HOT 1
- [bug]: contractcourt: max budget used immediately for anchor sweeps HOT 3
- [bug]: sweep: LinearFeeFunction off by one HOT 6
- [feature]: sweep: eliminate change address reuse HOT 2
- [bug]: sweep: AddWalletInputs modifies BudgetInputSet when error occurs
- [feature]: sweep: implement alternative fee functions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lnd.