Comments (2)
The trade off here is "address inflation" (which is why we cache the address in the first place). If each attempt got a new change address, then we'll quickly start to exceed the default "look ahead" distance for address rescans, which can make it difficult for users to recover from seed (need to set a distance of 10k, etc).
from lnd.
Address inflation is nice to avoid, but note that the current code does not prevent it entirely. It can still happen when BumpFee
is used, or if a counterparty's competing transaction confirms instead of ours.
We can limit the amount of address inflation while eliminating reuse by:
- ensuring that exclusive group inputs share the same change output
- caching change outputs for in flight transactions until we get a
Failed
orSwept
event. If we get aFailed
event, we can reuse that change output.
from lnd.
Related Issues (20)
- [Failing test]: Unexpected number of transactions in mempool in neutrino channel force closure itest
- `LeaseOutput` is slow with postgres backend HOT 1
- [bug]: confirmed funds gone after sweeping all tx HOT 1
- [bug]: routerClient.BuildRoute does not consider inbound fees HOT 5
- [feature]: Add `CanSend` amount to listchannels output HOT 1
- [feature]: sweep: batch inputs with similar deadlines HOT 1
- invoices lacking routing hints, made from zero_conf channels, yield "NO_ROUTE" on payment attempts in first few minutes of the channel's life HOT 4
- [epic]: ChannelDB, Graph, Gossiper and Router separation
- [epic]: Payment and Router separation
- [epic]: revive `ChannelRouter` as the layer 3 within the ln stack
- [bug]: Not able to bumpclosefee of an anchor channel in a special case (no HLTCs at stake). HOT 4
- References to known test flakes and planned fixes
- [bug]: Pending Force Close Channel with negative blocks till maturity. HOT 2
- build: enable coveralls as a required check
- [feature]: Persist imported Mission Control Data across restarts. HOT 4
- [bug]: On restart LND attempts to broadcast different FC tx for already closing channel, shuts down HOT 6
- [bug]: recent security vulnerability not listed on github security page HOT 1
- [feature]: scan new addresses based on gap limit
- [bug]: New healthcheck checkOutboundPeers triggers downtime HOT 13
- gossip: node announcement ignored because node not in graph HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lnd.