Comments (6)
@saubyk add to 18.0?
from lnd.
@saubyk add to 18.0?
makes sense. added.
from lnd.
cc: @yyforyongyu
from lnd.
But in the extreme case of a next-block deadline, LinearFeeFunction will return the min feerate instead of the max, which is quite bad.
What do you mean by saying next-block deadline? That we only have 1 block left till it times out? What is this min feerate?
from lnd.
What do you mean by saying next-block deadline? That we only have 1 block left till it times out? What is this min feerate?
Here's an example graph of the LinearFeeFunction
. The min feerate is the starting feerate. The max feerate is the ending feerate.
Now imagine we call SweepInput
with a deadline 1 block away. The fee function will be initialized with a width of 1 and starting feerate at the minimum of the feerate line. After 1 block (i.e. deadline missed), the feerate will be immediately bumped to the maximum of the feerate line.
But for this next-block deadline case, we really don't want a sloped line at all -- we want to start right at the maximum.
from lnd.
func (l *LinearFeeFunction) feeRateAtPosition(p uint32) chainfee.SatPerKWeight {
if p >= l.width - 1 {
return l.endingFeeRate
}
...
}
does this suggestion fix the issue located in /sweep/fee_function.go
from lnd.
Related Issues (20)
- [bug]: New healthcheck checkOutboundPeers triggers downtime HOT 13
- gossip: node announcement ignored because node not in graph HOT 3
- [bug]: can't build on debian HOT 9
- [meta]: Consider increasing column limit HOT 1
- [bug]: LND v0.18.0 - a recovery is not possible anymore HOT 13
- [bug]: payment_failure_reason > 0 when payment status = SUCCEEDED
- [bug]: GossipSyncer should remove unreliable Peers from syncing the ChannelGraph HOT 29
- failed to load config: ValidateConfig: unable to load RPC credentials for bcd: unable to extract RPC credentials HOT 12
- [bug]: BatchOpenChannel RPC will always use 6 confirmation target for the fee estimation HOT 3
- [bug]: lncli create is not honoring its documentation HOT 1
- [bug]: describegraph; node's last_update should include node's edges' last_update HOT 8
- discovery - [feature]: implement bandwidth based, daemon wide gossip rate limiting. HOT 1
- [bug]: channel automatically force closed with low fees and impossible to bumpfees; reimporting fails with "could not derive private key for legacy channel revocation root format: unable to derive private key" HOT 14
- chanbackup/[feature]: add archive mode for channel back ups
- [feature]: HOT 1
- [bug]: IPV6 generally does not work - connections to other nodes (in and out) HOT 1
- `routing`: `lnd` cannot shutdown due to `MissionControl`
- [bug]: lnd not resigning from leader role when disconnected from cluster HOT 4
- [feature] - routing: add additional validation to MPP related send payment params HOT 1
- Define `isLocalCommitTx` and refactor contractcourt to use it
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lnd.