Comments (11)
Chinwendu20
commented on May 23, 2024
1
Seems like there is a new line there already?
Line 142 in ab83343
from lnd.
Chinwendu20
commented on May 23, 2024
I am trying to reproduce it, so I started lnd (with the norest flag) and issued the command, lncli --stop.
from lnd.
C-Otto
commented on May 23, 2024
It's in the code and, if I understand the logging library correctly, that's not even necessary. However, I've seen the bug manifest itself several times, but not everytime I stop lnd.
from lnd.
MPins
commented on May 23, 2024
I did reproduce the problem. Actually I tested from the version v0.17.2-beta to 0.18.0-beta.rc1. The only version that we have missing newline in "Shutdown complete" is the v0.17.3-beta, curiously since v.0.17.4-beta we have a blank line after "Shutdown complete". See the logs below.
Version: 0.17.2-beta ------------------------------------------------------------------------------------------------------------------------
2024-05-04 00:37:37.207 [INF] LTND: Shutting down...
2024-05-04 00:37:37.207 [INF] LTND: Gracefully shutting down.
2024-05-04 00:37:38.177 [INF] RPCS: Stopping RPC Server
2024-05-04 00:37:38.177 [INF] RPCS: Stopping RouterRPC Sub-RPC Server
2024-05-04 00:37:38.177 [INF] RPCS: Stopping WatchtowerClientRPC Sub-RPC Server
2024-05-04 00:37:38.177 [INF] RPCS: Stopping NeutrinoKitRPC Sub-RPC Server
2024-05-04 00:37:38.177 [INF] RPCS: Stopping SignRPC Sub-RPC Server
2024-05-04 00:37:38.178 [INF] RPCS: Stopping VersionRPC Sub-RPC Server
2024-05-04 00:37:38.178 [INF] RPCS: Stopping WalletKitRPC Sub-RPC Server
2024-05-04 00:37:38.178 [INF] RPCS: Stopping WatchtowerRPC Sub-RPC Server
2024-05-04 00:37:38.178 [INF] RPCS: Stopping InvoicesRPC Sub-RPC Server
2024-05-04 00:37:38.178 [INF] RPCS: Stopping ChainRPC Sub-RPC Server
2024-05-04 00:37:38.178 [INF] RPCS: Stopping AutopilotRPC Sub-RPC Server
2024-05-04 00:37:38.178 [INF] RPCS: Stopping PeersRPC Sub-RPC Server
2024-05-04 00:37:38.178 [INF] LNWL: Stopped waiting for wallet sync due to error: wallet shutting down
2024-05-04 00:37:38.178 [INF] BTCN: Canceling block subscription: id=1
2024-05-04 00:37:38.228 [INF] BTCN: Block manager shutting down
2024-05-04 00:37:38.229 [INF] BTCN: Address manager shutting down
2024-05-04 00:37:38.231 [INF] LTND: Shutdown complete
2024-05-04 00:38:05.554 [WRN] LTND: open /root/.lnd/lnd.conf: no such file or directory
2024-05-04 00:38:05.554 [INF] LTND: Version: 0.17.2-beta commit=v0.17.2-beta, build=production, logging=default, debuglevel=info
Version: 0.17.3-beta ----------------------------------------------------------------------------------------------------------------------
2024-05-03 21:25:24.666 [INF] LTND: Shutting down...
2024-05-03 21:25:24.666 [INF] LTND: Gracefully shutting down.
2024-05-03 21:25:25.012 [INF] RPCS: Stopping RPC Server
2024-05-03 21:25:25.012 [INF] RPCS: Stopping NeutrinoKitRPC Sub-RPC Server
2024-05-03 21:25:25.013 [INF] RPCS: Stopping VersionRPC Sub-RPC Server
2024-05-03 21:25:25.013 [INF] RPCS: Stopping AutopilotRPC Sub-RPC Server
2024-05-03 21:25:25.013 [INF] RPCS: Stopping WatchtowerClientRPC Sub-RPC Server
2024-05-03 21:25:25.013 [INF] RPCS: Stopping ChainRPC Sub-RPC Server
2024-05-03 21:25:25.013 [INF] RPCS: Stopping SignRPC Sub-RPC Server
2024-05-03 21:25:25.013 [INF] RPCS: Stopping WalletKitRPC Sub-RPC Server
2024-05-03 21:25:25.013 [INF] RPCS: Stopping WatchtowerRPC Sub-RPC Server
2024-05-03 21:25:25.014 [INF] RPCS: Stopping InvoicesRPC Sub-RPC Server
2024-05-03 21:25:25.014 [INF] RPCS: Stopping RouterRPC Sub-RPC Server
2024-05-03 21:25:25.014 [INF] RPCS: Stopping PeersRPC Sub-RPC Server
2024-05-03 21:25:25.014 [INF] LNWL: Stopped waiting for wallet sync due to error: wallet shutting down
2024-05-03 21:25:25.014 [INF] BTCN: Canceling block subscription: id=1
2024-05-03 21:25:25.064 [INF] BTCN: Block manager shutting down
2024-05-03 21:25:25.064 [INF] BTCN: Address manager shutting down
2024-05-03 21:25:25.066 [INF] LTND: Shutdown complete2024-05-03 21:25:37.426 [WRN] LTND: open /root/.lnd/lnd.conf: no such file or directory
2024-05-03 21:25:37.426 [INF] LTND: Version: 0.17.3-beta commit=v0.17.3-beta, build=production, logging=default, debuglevel=info
Version: v0.17.4-beta -----------------------------------------------------------------------------------------------------------------------
2024-05-03 21:17:23.715 [INF] LTND: Shutting down...
2024-05-03 21:17:23.715 [INF] LTND: Gracefully shutting down.
2024-05-03 21:17:24.377 [INF] RPCS: Stopping RPC Server
2024-05-03 21:17:24.377 [INF] RPCS: Stopping WalletKitRPC Sub-RPC Server
2024-05-03 21:17:24.377 [INF] RPCS: Stopping WatchtowerRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping AutopilotRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping InvoicesRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping RouterRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping ChainRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping NeutrinoKitRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping VersionRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping SignRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping PeersRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] RPCS: Stopping WatchtowerClientRPC Sub-RPC Server
2024-05-03 21:17:24.378 [INF] LNWL: Stopped waiting for wallet sync due to error: wallet shutting down
2024-05-03 21:17:24.379 [INF] BTCN: Canceling block subscription: id=1
2024-05-03 21:17:24.429 [INF] BTCN: Block manager shutting down
2024-05-03 21:17:24.429 [INF] BTCN: Address manager shutting down
2024-05-03 21:17:24.431 [INF] LTND: Shutdown complete
2024-05-03 21:17:45.492 [WRN] LTND: open /root/.lnd/lnd.conf: no such file or directory
2024-05-03 21:17:45.492 [INF] LTND: Version: 0.17.4-beta commit=v0.17.4-beta, build=production, logging=default, debuglevel=info
Version: 0.17.5-beta ------------------------------------------------------------------------------------------------------------------------
2024-05-04 00:50:37.076 [INF] LTND: Shutting down...
2024-05-04 00:50:37.076 [INF] LTND: Gracefully shutting down.
2024-05-04 00:50:37.942 [INF] RPCS: Stopping RPC Server
2024-05-04 00:50:37.942 [INF] RPCS: Stopping InvoicesRPC Sub-RPC Server
2024-05-04 00:50:37.942 [INF] RPCS: Stopping PeersRPC Sub-RPC Server
2024-05-04 00:50:37.942 [INF] RPCS: Stopping WatchtowerClientRPC Sub-RPC Server
2024-05-04 00:50:37.942 [INF] RPCS: Stopping SignRPC Sub-RPC Server
2024-05-04 00:50:37.942 [INF] RPCS: Stopping VersionRPC Sub-RPC Server
2024-05-04 00:50:37.942 [INF] RPCS: Stopping AutopilotRPC Sub-RPC Server
2024-05-04 00:50:37.943 [INF] RPCS: Stopping WatchtowerRPC Sub-RPC Server
2024-05-04 00:50:37.943 [INF] RPCS: Stopping RouterRPC Sub-RPC Server
2024-05-04 00:50:37.943 [INF] RPCS: Stopping ChainRPC Sub-RPC Server
2024-05-04 00:50:37.943 [INF] RPCS: Stopping NeutrinoKitRPC Sub-RPC Server
2024-05-04 00:50:37.943 [INF] RPCS: Stopping WalletKitRPC Sub-RPC Server
2024-05-04 00:50:37.943 [INF] LNWL: Stopped waiting for wallet sync due to error: wallet shutting down
2024-05-04 00:50:37.943 [INF] BTCN: Canceling block subscription: id=1
2024-05-04 00:50:37.994 [INF] BTCN: Block manager shutting down
2024-05-04 00:50:37.994 [INF] BTCN: Address manager shutting down
2024-05-04 00:50:37.997 [INF] LTND: Shutdown complete
2024-05-04 00:50:44.836 [WRN] LTND: open /root/.lnd/lnd.conf: no such file or directory
2024-05-04 00:50:44.836 [INF] LTND: Version: 0.17.5-beta commit=v0.17.5-beta, build=production, logging=default, debuglevel=info
Version: 0.18.0-beta.rc1 ----------------------------------------------------------------------------------------------------------------------
2024-05-04 00:43:17.174 [INF] LTND: Shutting down...
2024-05-04 00:43:17.174 [INF] LTND: Gracefully shutting down.
2024-05-04 00:43:17.471 [INF] RPCS: Stopping RPC Server
2024-05-04 00:43:17.471 [INF] RPCS: Stopping NeutrinoKitRPC Sub-RPC Server
2024-05-04 00:43:17.471 [INF] RPCS: Stopping VersionRPC Sub-RPC Server
2024-05-04 00:43:17.471 [INF] RPCS: Stopping RouterRPC Sub-RPC Server
2024-05-04 00:43:17.471 [INF] RPCS: Stopping PeersRPC Sub-RPC Server
2024-05-04 00:43:17.471 [INF] RPCS: Stopping ChainRPC Sub-RPC Server
2024-05-04 00:43:17.471 [INF] RPCS: Stopping SignRPC Sub-RPC Server
2024-05-04 00:43:17.471 [INF] RPCS: Stopping WalletKitRPC Sub-RPC Server
2024-05-04 00:43:17.472 [INF] RPCS: Stopping WatchtowerRPC Sub-RPC Server
2024-05-04 00:43:17.472 [INF] RPCS: Stopping AutopilotRPC Sub-RPC Server
2024-05-04 00:43:17.472 [INF] RPCS: Stopping InvoicesRPC Sub-RPC Server
2024-05-04 00:43:17.472 [INF] RPCS: Stopping WatchtowerClientRPC Sub-RPC Server
2024-05-04 00:43:17.472 [INF] LNWL: Stopped waiting for wallet sync due to error: wallet shutting down
2024-05-04 00:43:17.472 [INF] BTCN: Canceling block subscription: id=1
2024-05-04 00:43:17.522 [INF] BTCN: Block manager shutting down
2024-05-04 00:43:17.522 [INF] BTCN: Address manager shutting down
2024-05-04 00:43:17.524 [INF] LTND: Shutdown complete
2024-05-04 00:43:26.850 [WRN] LTND: open /root/.lnd/lnd.conf: no such file or directory
2024-05-04 00:43:26.851 [WRN] LTND: Config 'bitcoin.active' is deprecated, please remove it
2024-05-04 00:43:26.851 [INF] LTND: Version: 0.18.0-beta.rc1 commit=v0.18.0-beta.rc1-16-g399ea864d, build=production, logging=default, debuglevel=info
from lnd.
saubyk
commented on May 23, 2024
So, this seems to be a non-issue in the releases after 17.3
Closing this issue now.
from lnd.
C-Otto
commented on May 23, 2024
@saubyk Please reopen, I just reproduced the issue with v0.18.0-beta.rc1. Let me know what kind of information you need to debug this.
2024-04-30 15:21:19.089 [INF] LTND: Version: 0.18.0-beta.rc1 commit=v0.18.0-beta.rc1, build=production, logging=default, debuglevel=info
[...]
2024-05-04 10:45:58.138 [INF] RPCS: Stopping AutopilotRPC Sub-RPC Server
2024-05-04 10:45:58.158 [INF] LTND: Shutdown complete2024-05-04 10:45:58.377 [INF] LTND: REST API is disabled!
2024-05-04 10:45:58.378 [INF] LTND: Version: 0.18.0-beta.rc1 commit=v0.18.0-beta.rc1, build=production, logging=default, debuglevel=info
2024-05-04 10:45:58.378 [INF] LTND: Active chain: Bitcoin (network=mainnet)
I'm starting/stopping/restarting lnd via systemd:
Type=simple
PIDFile=/home/bitcoin/.lnd/lnd.pid
ExecStart=/home/bitcoin/bin/lnd
from lnd.
C-Otto
commented on May 23, 2024
If I use lncli stop with systemd, I do not reliably get the "Shutdown complete" message:
2024-05-04 11:00:11.268 [INF] LTND: Received terminated
2024-05-04 11:00:11.268 [INF] LTND: Shutting down...
2024-05-04 11:00:11.268 [INF] LTND: Gracefully shutting down.
2024-05-04 11:01:11.715 [INF] LTND: REST API is disabled!
2024-05-04 11:01:11.717 [INF] LTND: Version: 0.18.0-beta.rc1 commit=v0.18.0-beta.rc1, build=production, logging=default, debuglevel=info
2024-05-04 11:01:11.717 [INF] LTND: Active chain: Bitcoin (network=mainnet)
from lnd.
Chinwendu20
commented on May 23, 2024
How are you viewing the logs if you are using systemd. Is it through lnd.log file located in the lnd's data directory? Or journalctl -u ?
Can you check both and see if the logs appear the same way?
I am assuming your lnd is built to output logs in the file and stdout. Also that journalctl outputs the logs from stdout.
from lnd.
C-Otto
commented on May 23, 2024
I'm using log files (lnd.log) only, no journalctl/syslog.
In my lnd.service: StandardOutput=null
from lnd.
MPins
commented on May 23, 2024
I did the tests on previous comment using docker images and command "lncli stop" and the problem occurred only on version: 0.17.3-beta.
I reproduced using "systemctl start lnd" and "systemctl stop lnd", them the bug exist since 0.17.3-beta until the current version.
See the logs below:
v0.17.2-beta (there is no problem) ----------------------------------------------------------------------------------------------------------------
2024-05-17 16:15:15.807 [INF] LTND: Version: 0.17.2-beta commit=v0.17.2-beta, build=development, logging=default, debuglevel=info
.
.
.
2024-05-17 16:16:17.234 [INF] LTND: Shutdown complete
2024-05-17 16:16:34.352 [INF] LTND: Version: 0.17.2-beta commit=v0.17.2-beta, build=development, logging=default, debuglevel=info
v0.17.3-beta -----------------------------------------------------------------------------------------------------------------------------------------------------
2024-05-17 16:10:36.927 [INF] LTND: Version: 0.17.3-beta commit=v0.17.3-beta, build=development, logging=default, debuglevel=info
.
.
.
2024-05-17 16:11:15.103 [INF] LTND: Shutdown complete2024-05-17 16:11:27.950 [INF] LTND: Version: 0.17.3-beta commit=v0.17.3-beta, build=development, logging=default, debuglevel=info
2024-05-17 16:11:27.951 [INF] LTND: Active chain: Bitcoin (network=testnet)
v0.17.4-beta ------------------------------------------------------------------------------------------------------------------------------------------------
2024-05-17 16:01:36.186 [INF] LTND: Version: 0.17.4-beta commit=v0.17.4-beta, build=development, logging=default, debuglevel=info
.
.
.
2024-05-17 16:02:26.142 [INF] LTND: Shutdown complete2024-05-17 16:02:42.429 [INF] LTND: Version: 0.17.4-beta commit=v0.17.4-beta, build=development, logging=default, debuglevel=info
2024-05-17 16:02:42.429 [INF] LTND: Active chain: Bitcoin (network=testnet)
v0.17.5-beta -------------------------------------------------------------------------------------------------------------------------------------------------
2024-05-17 15:25:50.340 [INF] LTND: Version: 0.17.5-beta commit=v0.17.5-beta, build=development, logging=default, debuglevel=info
.
.
.
2024-05-17 15:26:52.106 [INF] LTND: Shutdown complete2024-05-17 15:27:33.092 [INF] LTND: Version: 0.17.5-beta commit=v0.17.5-beta, build=development, logging=default, debuglevel=info
2024-05-17 15:27:33.092 [INF] LTND: Active chain: Bitcoin (network=testnet)
v0.18.0-beta.rc1 -------------------------------------------------------------------------------------------------------------------------------------------
2024-05-15 20:38:07.950 [WRN] LTND: Config 'bitcoin.active' is deprecated, please remove it
2024-05-15 20:38:07.950 [INF] LTND: Version: 0.18.0-beta.rc1 commit=v0.18.0-beta.rc1-dirty, build=development, logging=default, debuglevel=info
.
.
.
2024-05-15 20:39:13.205 [INF] LTND: Shutdown complete2024-05-15 20:39:36.520 [WRN] LTND: Config 'bitcoin.active' is deprecated, please remove it
2024-05-15 20:39:36.521 [INF] LTND: Version: 0.18.0-beta.rc1 commit=v0.18.0-beta.rc1-dirty, build=development, logging=default, debuglevel=info
from lnd.
Related Issues (20)
- [bug]: lncli openchannel breaking change - fee preference HOT 2
- NewAddress returns duplicate addresses HOT 4
- [feature]: unify address creation behavior between `BtcWalletKeyRing.DeriveNextKey` and `BtcWalletKeyRing.DeriveKey`
- [bug]: I'm completely unable to be synced with the Lightning network. HOT 2
- [bug]: Cannot send coins with 1 sat/vB HOT 6
- [bug]: Creating a new channel
- [bug]: sweep: data race on TxPublisher.currentHeight HOT 2
- [bug]: `ChannelRouter` cannot be shutdown while the `syncGraphWithChain` function is running. HOT 4
- [bug]: Inbound fees are not in the gossip message when using `subscribeChannelGraph` HOT 2
- [bug]: Ping time is not accurate HOT 1
- [feature]: lncli command for walletrpc.EstimateFee HOT 4
- [bug]: Unable to pay AMP invoice with `amp` flag set to true
- Add new RPCs to control the fee bumping process
- [bug]: sweep: BumpFee can cause transaction conflicts HOT 1
- [bug]: contractcourt: max budget used immediately for anchor sweeps HOT 3
- [bug]: sweep: LinearFeeFunction off by one HOT 6
- [feature]: sweep: eliminate change address reuse HOT 2
- [bug]: sweep: AddWalletInputs modifies BudgetInputSet when error occurs
- [feature]: sweep: implement alternative fee functions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lnd.