Comments (3)
For the outbound fee, I think it makes sense to set a non-zero default. But for the inbound fee, I'd say that zero (no discount) is a logical default.
Any ideas on what the use case could be for a discount by default?
from lnd.
I think a global value that when modified would also apply to all existing channels that use default fees could perhaps be useful, but as far as I know it isn't implemented like that.
Currently the config value is almost alike a hidden parameter to the api call. I think it is debatable whether that is good api design. In the past, there has been confusion with default values on the api level. The most prominent example of that may have been the default fee limit for payments (100% of payment amount). My impression was that forcing api users to set the value has been an improvement.
For consistency I understand that you might want the inbound fee default in the config file, but it does feel like a step in the wrong direction. Removing the outbound fee default and making it an explicit parameter in the api call to me feels like the better direction.
The one place where in and out defaults are needed, I think, is when accepting a channel from a peer. But those defaults could be explicitly limited to that scope.
from lnd.
But for the inbound fee, I'd say that zero (no discount) is a logical default.
Yeah agreed re zero as a default.
The gap here is that users right now must use the RPC/CLI to set the value each time vs being able to set a global value using the config here like all the other fee/routing knobs.
from lnd.
Related Issues (20)
- [bug]: lncli openchannel breaking change - fee preference HOT 2
- NewAddress returns duplicate addresses HOT 4
- [feature]: unify address creation behavior between `BtcWalletKeyRing.DeriveNextKey` and `BtcWalletKeyRing.DeriveKey`
- [bug]: I'm completely unable to be synced with the Lightning network. HOT 2
- [bug]: Cannot send coins with 1 sat/vB HOT 6
- [bug]: Creating a new channel
- [bug]: Regression: Missing newline in "Shutdown complete" log message HOT 11
- [bug]: sweep: data race on TxPublisher.currentHeight HOT 2
- [bug]: `ChannelRouter` cannot be shutdown while the `syncGraphWithChain` function is running. HOT 4
- [bug]: Inbound fees are not in the gossip message when using `subscribeChannelGraph` HOT 2
- [bug]: Ping time is not accurate HOT 1
- [feature]: lncli command for walletrpc.EstimateFee HOT 4
- [bug]: Unable to pay AMP invoice with `amp` flag set to true
- Add new RPCs to control the fee bumping process
- [bug]: sweep: BumpFee can cause transaction conflicts HOT 1
- [bug]: contractcourt: max budget used immediately for anchor sweeps HOT 3
- [bug]: sweep: LinearFeeFunction off by one HOT 6
- [feature]: sweep: eliminate change address reuse HOT 2
- [bug]: sweep: AddWalletInputs modifies BudgetInputSet when error occurs
- [feature]: sweep: implement alternative fee functions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lnd.