[bug]: Incorrect clear_balace value after cooperative channel close if funds are sent to an address that does not belong to the given lnd about lnd HOT 1 OPEN

Thanks for the issue report @kulisekf!

I've reproduced the issue and have verified that "settled_balance" indeed doesn't include the local balance if a non wallet close_address is passed when opening the channel.

The issue is that in chain_watcher.go we assign the value for the SettledBalance to the local localAmt variable:

The localAmt variable is assigned at:

Now the toSelfAmount func will currently only return balance for addresses which are controlled by the wallet due to the definition of the isOurAddr func, and not for non wallet addresses, despite the fact the address has been sent in as our close_address for the channel.

That behaviour would need to be changed in order to solve this issue.

I think a potential solution would be to modify the isOurAddr func that is sent in to chainWatcher, and that the function also matches against the close_address if one has been set. Though I haven't verified if this would work as expected nor if this is the optimal solution.

The isOurAddr func would also need to be updated if an address is passed as the delivery_addr during the closechannel call.

from lnd.