Git Product home page Git Product logo

Comments (4)

TheBlueMatt avatar TheBlueMatt commented on July 18, 2024 1

Oops, yea, the sample was being lazy about calculating the change output, but we also don't even need to calculate it anymore since LDK started doing that a few versions ago. Should be fixed in #32.

from ldk-sample.

jkczyz avatar jkczyz commented on July 18, 2024

Yup, looks like fee_rate(sat/vB) was added in 0.21 whereas feeRate (BTC/kvB) was the only option earlier.

from ldk-sample.

t-bast avatar t-bast commented on July 18, 2024

Right, if you only support bitcoind 0.21 (and higher) that works for me as well, I'll retry with that version.

from ldk-sample.

t-bast avatar t-bast commented on July 18, 2024

I updated to bitcoind 0.21.1 which fixed the previous panic, but now I'm seeing a different one:

> openchannel 03f1730317981052d10403126e197e421875711898411802e47067401eecd4fab3@localhost:9735 250000
EVENT: initiated channel with peer 03f1730317981052d10403126e197e421875711898411802e47067401eecd4fab3. 
> thread '<unnamed>' panicked at 'assertion failed: change_output_position == 0 || change_output_position == 1', src/main.rs:133:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)

Unfortunately I don't see the tx in the logs, but I suspect there's simply no change output (is that correctly handled on your side)?

from ldk-sample.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.