Get Wallet Balance about ldk-sample HOT 8 CLOSED

I checked in Discord about this and they recommended to use rpc directly to get the balance. I tried this in a local branch and it worked.

New match case in poll_for_user_input function.

"walletbalance" => {
    let runtime =
        tokio::runtime::Builder::new_current_thread().enable_all().build().unwrap();
    runtime.block_on(wallet_balance(bitcoin_client.clone()));
    continue;
}

Function for returning the wallet balance.

async fn wallet_balance(bitcoin: Arc<BitcoindClient>) {
	let params: &[serde_json::Value] =
		&[serde_json::Value::String("*".to_string()), serde_json::Value::Number(6.into())];
	let available_balance: serde_json::Value =
		bitcoin.bitcoind_rpc_client.call_method("getbalance", params).await.unwrap();
	println!("balance: {}", available_balance);
}

from ldk-sample.

Good day @spirrello can I contribute to this?

from ldk-sample.

Good day @spirrello can I contribute to this?

@ikeogu yes absolutely

from ldk-sample.

Alright, please can you assist me with more details?

from ldk-sample.

please can I get more clarity , and also how to raise the PR.

from ldk-sample.

Given this is just a sample focused on how to interact with LDK, I'm not sure we want a method to fetch the Bitcoin Core balance. That's generally outside the scope of LDK and more "stuff" in the sample detracts from the goal of an easy-to-read small-ish codebase.

from ldk-sample.

alright @TheBlueMatt , let me find another issue to resolve.

from ldk-sample.

Thanks, @ikeogu!

Closing this as not planned.

from ldk-sample.