Comments (3)
Hello! I'm consider making a PR adding this functionality sometime soon.
I saw in #50 it seems like this might be another thing that we wouldn't want to add a dependency for? I'm pretty new to contributing here, so I am actually not super certain on the overall mindset regarding dependencies. I'd imagine it's mainly because it's a security risk, and that it can add unnecessary complexity to a project? I'll plan on trying to make a PR without adding this dependency for now.
from ldk-sample.
ldk-sample
is...a sample. Adding a lot of complexity to it to make it super duper user-friendly is an explicit non-goal - its code should stay simple to demonstrate how to build an LDK application, not add complexity to be super user-friendly. Both as a sample and as a demonstration of best-practices we also don't want to add dependencies unless we have a strong reason to believe we cannot reproduce the feature simply.
For the first reason I don't think we should bother with this at all, for the second we shouldn't add a dependency to do so.
from ldk-sample.
Ah makes sense, thanks!
from ldk-sample.
Related Issues (20)
- Announce node_announcemnet even without listen addresses
- Dont unwrap `spend_spendable_outputs`
- Expose start_ldk in a library? HOT 3
- Include channel info in `SpendableOutput`s HOT 1
- Anchor Channels
- Update bitcoin library HOT 2
- Get Wallet Balance HOT 8
- Switch to using payment_parameters_from_invoice for decoding payment parameters HOT 1
- Parse .env or environment variables for RPC auth details HOT 5
- Use named arguments instead of a predefined sequence for RPC authentication HOT 3
- panic on pubkey too short
- Does LDK already support production environment (BTC mainnet) use? HOT 2
- Paying to SBW testnet leads to routing failure HOT 9
- Race Between Initial Block Hashes can cause panic
- Catch ^C HOT 2
- Update CI with Node16-compatible actions
- 'Invalid branch name' on cloning the repo HOT 2
- Persist payment info to disk HOT 2
- Store bash history for recalling commands with up arrow HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ldk-sample.