Persist payment info to disk about ldk-sample HOT 2 CLOSED

One approach may be to wait for lightningdevkit/rust-lightning#1823 to land and then use that to implement Readable and Writeable so that we can persist it trivially like you suggest.

That makes sense, I'll probably wait for this.

I've mainly been looking for ways to build up my confidence contributing before jumping into rust-lightning, but I realize this sample repo probably doesn't need much work done on it, so I'll probably go pick up a good first issue there sometime soon! Anyway, thanks for the feedback!

from ldk-sample.

Sure, if you want to. Because this is ultimately sample code, we should seek to ensure the implementation of everything is super straightforward, simple, and readable, and not care too much about performance or even feature-completeness. So, if we can't do this in a way that meets those goals, we shouldn't bother.

With that in mind, we'll probably want to abstract out the PaymentInfoStorage from a simple mutex to a struct which implements writing to some (trivial) DB. I don't think we want to bother taking on a dependency for a database, so we'll have to come up with something simple, like writing it all out to a flag file with Writeable/Readable like you suggest. One approach may be to wait for lightningdevkit/rust-lightning#1823 to land and then use that to implement Readable and Writeable so that we can persist it trivially like you suggest.

from ldk-sample.