Missing 'x' argument in gsub about complex-upset HOT 5 CLOSED

Sure, I'll put one together

from complex-upset.

Thank you for your insight! Would you like to create a pull request with your improvements?

from complex-upset.

Actually, your names_of_true3 will not protect a user who has a data.frame with columns named: c('a-b', a_b') from a distortion of the data (which is what I aimed for). Either way, I agree that there is a bug with x missing in gsub, and that this function can be optimized up in a way or two.

from complex-upset.

I see what you mean, perhaps then the easiest solution is check for '-' and then check for duplicated names and then repair as necessary. I'll put something together tomorrow

from complex-upset.

I have fixed the issue with a missing argument for names and added tests, but you are very welcome to contribute a better implementation of this function. I hope that the addition of the tests will make it easier to contribute. Any questions - let me know.

from complex-upset.