Git Product home page Git Product logo

Comments (5)

knorth55 avatar knorth55 commented on August 15, 2024 1

#403 is merged. please use origin/master branch to avoid messing up the google drive directory.

from jsk_3rdparty.

mqcmd196 avatar mqcmd196 commented on August 15, 2024

I use Fetch's one, launching gdrive_ros with Fetch's credential.

from jsk_3rdparty.

mqcmd196 avatar mqcmd196 commented on August 15, 2024

When sending image with google chat, permanent link is required for viewing image. So google_chat_ros uploads image with gdrive, and gets its link

from jsk_3rdparty.

knorth55 avatar knorth55 commented on August 15, 2024

@mqcmd196
thank you for your information!

I find out that chat notification images are all save in root directory of dialoglflow user's google drive.
this is because this line only specify the filename, not parent name.

Screenshot from 2022-11-29 16-29-29

jsk_3rdparty/google_chat_ros/scripts/google_chat_ros_node.py

Line 414 in a8464dc

res = gdrive_upload(file_path=filepath)

can you change to save in directory something line chat_notification?

jsk_3rdparty/gdrive_ros/node_scripts/gdrive_server_node.py

Lines 87 to 104 in a8464dc

if parents_id and parents_path:
rospy.logerr('parents_path and parents_id is both set.')
rospy.logerr(
'parents_id: {} is selected to upload.'.format(parents_id))
parents_path = ''
if parents_path:
try:
parents_id = self._get_parents_id(
parents_path, mkdir=True)
except (ValueError, ApiRequestError, ServerNotFoundError) as e:
rospy.logerr(e)
rospy.logerr(
'Failed to get parents_id: {}'.format(parents_path))
return res
# root
elif parents_id == '' and parents_path == '':
parents_id = ''

I also recommend to save in timestamp directory.

jsk_3rdparty/gdrive_ros/node_scripts/gdrive_server_node.py

Line 106 in a8464dc

if req.use_timestamp_folder:

so the directory tree should be

root/chat_notification/20221128/hoge.png

from jsk_3rdparty.

knorth55 avatar knorth55 commented on August 15, 2024

I made a PR for this issue.
#403

from jsk_3rdparty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.