Comments (5)
Hmm good point. We should generate the cache filename from relative paths
from wpthumb.
+1
from wpthumb.
That's what I thought... My concern was with backwards comparability though. Not that it would break, but that you could end up with a lot of duplicate cached images.
On 14 May 2012, at 10:12, Joe [email protected] wrote:
Hmm good point. We should generate the cache filename from relative paths
Reply to this email directly or view it on GitHub:
#18 (comment)
from wpthumb.
Yes, this is an issue. Changing any behaviour is problematic. I think we may have to build in some kind of versioning backwards compat for when we make this kind of changes,
On Monday, 14 May 2012 at 10:11, Matthew Haines-Young wrote:
Just wondering what you think about this @joehoyle
The filename is generated using the Args and the file path.
If you move the site to a new server, the file path will probably be different.
This is an issue for inline images added to the post content if the cache folder is not moved - as the new image will have a different filename.
Not really sure if this is a bug as such, and inline images will always cause problems as they would not cause WPthumb to regenerate the thumbnail anyway so we are always reliant on the cache folder but I just thought I would mention it as it doesn't seem ideal.
Reply to this email directly or view it on GitHub:
#18
from wpthumb.
I think doing this will rely on #21
from wpthumb.
Related Issues (20)
- Allow for limiting image sizes based on post type HOT 2
- Create 0.10 release tag HOT 3
- copy&pasted comment
- Add composer support HOT 1
- Unit tests are failing on Travis
- Clearing of cache folder HOT 4
- double slash on cache upload path HOT 1
- Jpeg_quality HOT 5
- Non-standard file extensions return incorrect cached filename
- Centering watermark
- wpthumb not working in production
- Imagick never used as editor
- Cache folder URL HOT 2
- Wordpress repo
- Multiple filters
- Filter `get_home_path()` HOT 1
- Any alternative to WPThumb HOT 3
- Add ability to provide a fallback color for backgorund_fill=auto
- Am I right to assume that this plugin slows down the WP media manager? HOT 3
- wordpress.org version needs updating HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wpthumb.