Git Product home page Git Product logo

Comments (5)

ambienthack avatar ambienthack commented on June 20, 2024

Same issue. Same fix worked for me.

from wpthumb.

rpetersn avatar rpetersn commented on June 20, 2024

THANK YOU! Working for me....

For reference, I added:

$editor->set_quality($this->args['jpeg_quality']);

to wpthumb.php at around line 429

from wpthumb.

willmot avatar willmot commented on June 20, 2024

If one of you fancies having a bash at sending a Pull Request be happy to merge 👍

from wpthumb.

sleepingkiwi avatar sleepingkiwi commented on June 20, 2024

Correct me if I'm wrong but I believe that recent PR only applies the quality change if the image is a .gif?
It appears inside the statement at line 425:
if ( $this->getFileExtension() == 'gif' ) :

To get the quality argument to apply for images other than gifs I had to move the line $editor->set_quality( $this->args['jpeg_quality'] ); outside of that if statement.

Additionally I'd recommend moving it below the line:
apply_filters( 'wpthumb_image_pre', $editor, $this->args );
as I believe the intent of that filter is to give users a chance to step in and make changes before any alterations have been made to the image by WPThumb?

Would be happy to send a PR with those changes if I haven't missed the point somewhere!

from wpthumb.

Colir avatar Colir commented on June 20, 2024

+1

from wpthumb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.