Git Product home page Git Product logo

Comments (1)

NathanLovato avatar NathanLovato commented on June 4, 2024

Hi, thanks for your interest in contributing to the project! And sorry for the reply delay; we have lots on our plates.

For the implementation, I'd go with either a steering equation (vector calculations) or using spherical-lerp with quaternions perhaps. This would make the code a bit simpler to read and edit.

If you use a timer to check for input, I wouldn't also have a boolean to check if the mouse has been touched. You could instead check if the timer is running or not. I don't have all the code in mind for this project, but I'd also ideally keep the camera code in the CameraController script over splitting logic between the camera and player controller scripts.

Let me know if you have any questions. Don't hesitate to open a PR directly with the change, and if it's okay with you, I could directly edit the code and comment where I'd make changes. That's how we usually do reviews in our team. A little extra note: please use snake case and no abbreviations in variable or function names.

from godot-4-3d-third-person-controller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.