Comments (1)
Hi, thanks for your interest in contributing to the project! And sorry for the reply delay; we have lots on our plates.
For the implementation, I'd go with either a steering equation (vector calculations) or using spherical-lerp with quaternions perhaps. This would make the code a bit simpler to read and edit.
If you use a timer to check for input, I wouldn't also have a boolean to check if the mouse has been touched. You could instead check if the timer is running or not. I don't have all the code in mind for this project, but I'd also ideally keep the camera code in the CameraController script over splitting logic between the camera and player controller scripts.
Let me know if you have any questions. Don't hesitate to open a PR directly with the change, and if it's okay with you, I could directly edit the code and comment where I'd make changes. That's how we usually do reviews in our team. A little extra note: please use snake case and no abbreviations in variable or function names.
from godot-4-3d-third-person-controller.
Related Issues (20)
- Replace CSG mesh with SurfaceTool for grenade path preview
- [Tracker] Improvements and fixes to improve the demo HOT 2
- Missing textures in Linux CI export HOT 3
- Add dedicated sound effects
- Various load errors due to missing files HOT 1
- Project fails to run in 4.0.2 HOT 2
- Camera rotation speed is effected by framerate.
- Update to latest version of Godot 4 HOT 8
- Pressing "Esc" twice, pauses the game but doesn't show any menu
- Cannot infer the type of "next_location" variable because the value doesn't have a set type. HOT 2
- HitBox/HurtBox
- `res://Enemies/smoke_puff/smoke_ball.tres` sometimes fails parsing, and invalid UID warning spam
- Player's `heart_core_mat.tres` `emission_energy_multiplier` changes value every time the main scene is saved HOT 1
- Trying to assign value of type 'MeshInstance3D' to a variable of type 'RigidBody3D'. HOT 1
- Misspelling in JumpingPad.gd Script
- Parser Error: Cannot infer the type of "next_location" variable because the value doesn't have a set type. HOT 2
- Known issue: beetle animations are broken in beta 17 HOT 11
- Extract photo mode to an addon
- Set all objects to use default layers and masks
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godot-4-3d-third-person-controller.