Git Product home page Git Product logo

Comments (2)

duracelltomi avatar duracelltomi commented on July 17, 2024

Hi David,

Thanks for sharing your findings!
There is a check on line 691 that was added to detect whether an adblocker is active that also blocks GTM:
https://github.com/duracelltomi/gtm4wp/blob/master/integration/woocommerce.php#L691

If I correctly understand you, this means that using this ad blocker the google_tag_manager global variable is still set?

About the preventDefault() and the callback: without this, the product click would immediately tell the browser to follow the link in the element. Although GTM would start to fire corresponding tags, execution of those code could be shut down since the browser replaces the current page with the new one.

Using this behavior, we allow GTM to fire all tags that is bound to the GTM event (gtm4wp.productClickEEC) and we instruct the browser to follow the link just after tags has been fired OR 2000ms has been passed as there is a timeout value in my code as well.
Unfortunately if GTM is blocked, this timeout value does not take into account as well but eventually the check at line 691 should prevent the whole product click event handler to execute.

I hope that helps to clarify the reasons and I hope we can find an even better solution to detect this ad blocker as well.

from gtm4wp.

DavidKox avatar DavidKox commented on July 17, 2024

Update fixed it for me - We were still running on v1.5 without the block-controller.

from gtm4wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.