Git Product home page Git Product logo

Comments (9)

deanm avatar deanm commented on August 24, 2024

Can you attach an example (code and output)? I will have a look.

Thanks

from omggif.

RobbieOnGithub avatar RobbieOnGithub commented on August 24, 2024

Of course - sorry about not attaching it originally: http://108.171.176.74/~rtilton1/thesis/360gifExport/

I'm console.logging the angle of my camera to make sure it's calling addFrame on each angle of the 360 rotation. The console output looks good, but at the end of the gif there's a little blip.

Thanks so much for looking into this!

from omggif.

deanm avatar deanm commented on August 24, 2024

I haven't had a chance to look at it very closely yet, but I saw that in the end you're adding it to the page with a data uri. In general data URIs are meant to be short, any chance you're hitting a limit? (For example Chrome is 2M, see https://code.google.com/p/chromium/issues/detail?id=44820)

from omggif.

deanm avatar deanm commented on August 24, 2024

Just a quick look shows the output GIF is 2573669 bytes long, which ends up with a URI of 3431582 bytes. I'm not sure what Chrome will do but I think there is a really good chance it will get truncated...

from omggif.

RobbieOnGithub avatar RobbieOnGithub commented on August 24, 2024

Very interesting and thanks for looking into it. I didn't think about that before, but it definitely seems like this could be the cause of the problem. Do you know of a way that I might be able to get around this? I don't necessarily need to add the gif to the page - I just need to download or save it in some fashion. Thanks again for all the support!

from omggif.

deanm avatar deanm commented on August 24, 2024

I haven't tried... but maybe:

https://github.com/eligrey/FileSaver.js

It seems to use createObjectURL for a blob object...

from omggif.

deanm avatar deanm commented on August 24, 2024

I've also just fixed a bug (see #5) that could have possibly been related, but I'm not sure it would have been the problem. Anyway, would be good to grab an updated copy anyway.

from omggif.

RobbieOnGithub avatar RobbieOnGithub commented on August 24, 2024

This fixed it!!! Thanks so much!!!!

from omggif.

DanielBaird avatar DanielBaird commented on August 24, 2024

Sooo.. this can be closed then, right?

from omggif.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.