Are you accepting PRs? about omggif HOT 4 CLOSED

Project is alive. Can you open a bug for 1) and attach the malformed gif?

from omggif.

Great to hear! I've made about 4 mods to support my GIF library. I've fixed the infinite loop bug and am also catching the case where the provided buffer is too small.

I'd prefer to publish my library before asking for the mods, so you can see the need for them.

Still, I'm extremely impressed with how many GIF variations omggif supports despite not having a test suite! My suite tests quite a bit of it, because I'm using it as my default codec.

So let me get back with you next week.

from omggif.

Okay, thanks! I'm definitely for improving robustness (as long as of course there isn't a performance regression). If I have to choose between robustness (on invalid input) and performance (on valid input), in omggif's case I will go with the latter. If it's a wash than obviously robuster is better. As per the difference of throwing strings or Error, I have to admit this is a topic I will need to do a little bit of reading about. I've never had problems with stack traces when throwing strings, but realize there will be some programatic differences in terms of not having the properties of the Error object.

from omggif.

Okay, I've finally posted my GIF library (gifwrap) and so am ready to provide a PR. I'll post three issues and then a PR for all three. One moment...

from omggif.