Comments (2)
I have a workaround basically by checking the previous frameInfo disposal value and if it's 2 clear the pixel buffer, however i really should be clearing to the indexed background color palette value rather than just assuming it's 0x00000000. I didn't really see an easy way to get to that with the code.
var dispose_last_frame = true;
for(var i = 0; i < gr.numFrames(); ++i) {
if(dispose_last_frame) {
pixel_data.fill(0, 'hex');
console.log('clearing before frame: ' + i)
}
dispose_last_frame = (gr.frameInfo(i).disposal == 2)
gr.decodeAndBlitFrameRGBA(i, pixel_data);
frame_data.push(Buffer.from(pixel_data));
}
from omggif.
Sorry, maybe it's not clear but decodeAndBlitFrame is not meant to handle the disposal, for example see:
https://github.com/deanm/omggif/blob/master/plask_viewer.js#L30
I should mention, there is sometimes big differences between what the spec said, and what browsers / others did with GIFs over the years. So really there is sort of an unspoken spec of the reality of GIF, I don't remember all the details now but I know there were a lot of things around disposal where basically nobody follows the spec. It could make sense to add a helper method to omggif to get the background RGBA for example, taking care to handle transparent index, etc, there is a little bit of work to do there and deal with the cascade of the local/global palette etc.
from omggif.
Related Issues (20)
- Please add license file HOT 2
- Combine frames with transparency HOT 3
- Quantization and efficient frame encoding
- Are you accepting PRs? HOT 4
- Infinite loop on truncated GIF HOT 3
- Unhelpful exception on exceeding buffer bounds HOT 5
- Exceptions do not include a stack trace
- Enumerate public API? HOT 3
- Blending operations in GIFs HOT 2
- Upload to bower
- Loop count when exporting GIF HOT 9
- Get global palette from GIF HOT 6
- Invalid Block Size HOT 5
- Supporting corrupted GIFs to some degree HOT 2
- Attempt to use undefined value HOT 1
- MIT license? HOT 3
- Corrupted GIF at the output HOT 4
- frame ghosting and partial frames HOT 1
- gifReader.decodeAndBlitFrameRGBA(frameNumber, pixels) does not work for higher frame HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from omggif.