cyanilux / urp_blitrenderfeature Goto Github PK

I just tried switching to cmd-drawMesh but can't figure out how to get the depth texture. It seems that the screenmesh is included somehow?

I get the following warning on compile:

'RenderTargetHandle' is obsolete: 'Deprecated in favor of RTHandle'

'ScriptableRenderPass.Blit(CommandBuffer, RenderTargetIdentifier, RenderTargetIdentifier, Material, int)' is obsolete: 'Use RTHandles for source and destination'

'ScriptableRenderer.cameraColorTarget' is obsolete: 'Use cameraColorTargetHandle'

The last one is easy to fix, simply switching to "cameraColorTargetHandle" works.

Changing m_TemporaryColorTexture and m_DestinationTexture are similarly easy, following this guide:

https://forum.unity.com/threads/rendertargethandle-is-obsolete-deprecated-in-favor-of-rthandle.1211052/

But any further change proved extremely hard to fix and debug.

I have a shader like this

Shader "Custom/AnimeLine"
{
    Properties
    {
        _BaseColor("BaseColor", Color) = (1, 1, 1, 1)
        _SecondColor("Second Color", Color) = (1,1,1,1)
//        _thirdColor("Third Color", Color) = (1,1,1,1)
        _BaseMap("BaseMap", 2D) = "white" {}
        _Center ("Center", Vector) = (0.5, 0.5, 0, 0)
        _RotateSpeed ("Rotate Speed", Range(0,5)) = 0.2
        _RayMultiply ("RayMultiply", Range(0.001, 10)) = 7.5
        _RayPower ("RayPower", Range(0, 15)) = 3.22
        _Threshold ("Threshold", Range(0, 1)) = 1
    }

    SubShader
    {
        Tags { "Queue" = "Transparent" "RenderType" = "Transparent" "RenderPipeline" = "UniversalPipeline" "IgnoreProjector" = "True" }

        Pass
        {
            Tags {"LightMode" = "UniversalForward"}
            
            Blend SrcAlpha OneMinusSrcAlpha
            ZWrite Off

            HLSLPROGRAM
	        #pragma vertex vert
            #pragma fragment frag

            #include "Packages/com.unity.render-pipelines.universal/ShaderLibrary/Core.hlsl"

            struct Attributes
            {
                float4 positionOS : POSITION;
                float2 uv : TEXCOORD0;
            };

            struct Varyings
            {
                float2 uv : TEXCOORD0;
                float4 positionHCS : SV_POSITION;
            };

            TEXTURE2D(_BaseMap);
            SAMPLER(sampler_BaseMap);

            CBUFFER_START(UnityPerMaterial)
                float4 _BaseMap_ST;
                half4 _BaseColor;
                half4 _SecondColor;
                // half4 _thirdColor;
                half4 _Center;
                half _RotateSpeed;
                half _RayMultiply;
                half _RayPower;
                half _Threshold;
            CBUFFER_END

            Varyings vert(Attributes IN)
            {
                Varyings OUT;
                VertexPositionInputs vertexInput = GetVertexPositionInputs(IN.positionOS.xyz);
                OUT.positionHCS = vertexInput.positionCS;
                OUT.uv = TRANSFORM_TEX(IN.uv, _BaseMap);
                return OUT;
            }

            half4 frag(Varyings IN) : SV_Target
            {
                half2 uv = IN.uv - _Center.xy;

                half angle = radians(_RotateSpeed * _Time.y);

                half sinAngle, cosAngle;
                sincos(angle, sinAngle, cosAngle);

                half2x2 rotateMatrix0 = half2x2(cosAngle, -sinAngle, sinAngle, cosAngle);
                half2 normalizedUV0 = normalize(mul(rotateMatrix0, uv));

                half2x2 rotateMatrix1 = half2x2(cosAngle, sinAngle, -sinAngle, cosAngle);
                half2 normalizedUV1 = normalize(mul(rotateMatrix1, uv));
                
                half4 textureMask = SAMPLE_TEXTURE2D(_BaseMap, sampler_BaseMap, normalizedUV0) * SAMPLE_TEXTURE2D(_BaseMap, sampler_BaseMap, normalizedUV1);

                half uvMask = pow(_RayMultiply * length(uv), _RayPower);

                half mask = smoothstep(_Threshold - 0.1, _Threshold + 0.1, textureMask.r * uvMask);

                half mask2 = smoothstep(_Threshold - 0.1, _Threshold + 0.1, textureMask.g * 2 * uvMask);

                // half mask3 = smoothstep(_Threshold - 0.1, _Threshold + 0.1, textureMask.b * 50 * uvMask);

                // half4 res = lerp(lerp(half4(_BaseColor.rgb, mask * _BaseColor.a), half4(_SecondColor.rgb, mask2 * _SecondColor.a), mask2 - mask), half4(_thirdColor.rgb, mask3 * _thirdColor.a), mask3 - mask2 - mask);
                 half4 res = lerp(half4(_BaseColor.rgb, mask * _BaseColor.a), half4(_SecondColor.rgb, mask2 * _SecondColor.a), mask2 - mask);

                return res;
            }
            ENDHLSL
        }
    }
}

And the result is

I change event to "Before Rendering Post Processing" and it shows my shader works without my expectation. If I set the event to "After Rendering Opaques" it shows nothing.

Can it blend with background?

Hi,

This feature works fine in mono rendering. But for Stereo rendering for VR it just draws a solid colour.
I'm not sure if its a shader issue or not, but im using shader graph.
Unity 2019.4.21f1
URP 7.3.1

Hello, I am using a Render Texture that is generated at runtime when the resolution of the screen changes (I think it is better to render at the native resolution and not above since it will be full screen).

At first, I was using a canvas and a Raw Image, but that didn't feel like the correct way to put the Render Texture onto the screen.

Then I found about this, and It works perfectly with an asset Render Texture but if I change it at runtime unity complains about “Type Mismatch”.
I think it's because the URP Renderer is an asset, and I'm trying to make it reference something that is not an asset.

How can use a runtime Render Texture as a source ?

Hi, sorry for the new issue so soon, but diving into the code it's apparent that my usage of the project requires one blit to apply the material, and then another to move back the new data to the main render texture

Is there a simple way to avoid this problem and minimize the number of blits required?

Hi, this feature is working fine on my project :)

but I want to ask if there have a way to change blit material in run time through script?
I am not familiar with scriptable render pipeline and I can't find any useful information about it.

It will be a big thanks if you can tell me about it!

Hey. First, awesome work! I'm trying to setup your WatercolourShaders with an occulus quest 2, and because of XR, I switched the blitRenderFeature to the cmd-drawMesh version.

Without the cmd-drawMesh version,

• if I play in the editor (processed by the computer and sent to the headset for display), everything is working fine.
• if I build and play (processed directly by android on the headset), I'm having huge weird color lines over the render in the headset (but I guess it's because of the incompatibility with XR)

With the cmd-drawMesh version,

• In both case, I'm having only the "outlines" rendered (the ones created by the edge detection in the shadergraph), but everything else is white (sure the effect is cool, but not what I expect ;) ). I'm using the BlitDirectly shader in the "always include" graphic setting, and I can't understand why I'm having this issue...

Any idea how to solve this issue?
Thanks in advance!

On Unity 2021.2.2f1, the Blit feature does not work. Strangely, it seems to work in the preview window. I have seen this happen with the original blit feature and now it does not work anymore. Is there a fix to this?

The feature works as intended but it has a side effect on how Unity Preview assets.

Some Examples

Some of my prefabs:

Some of my materials:

The preview of the .fbx asset:

The Main Preview window inside Shader Graph view:

Tried to add ECS to my project, upgraded URP and unity

Sadly whenever the package manager tries to install BitRenderFeature, it fails with this error

[Package Manager Window] Error adding package: com.cyanilux.urp-blitrenderfeature@https://github.com/Cyanilux/URP_BlitRenderFeature.git.
ENOTEMPTY: directory not empty, rmdir 'pojectdir\Library\PackageCache\.tmp-13968-EFB7LJGCNbRz'
UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

Hey. Sorry opening another issue and I am uncertain if this is the right place to ask. But I tested the shaders on my machine and pcvr setups. But I also build my game for the Quest 2 but I get these weird "artifacts" when turning the screen white, I also use a fragment shader to do a small "screenshake" but that makes the whole game visually jitter. It feels like the renderer on the oculus does something with / to it.

I am using the 'cmd-drawMesh' branch.

Some added pictures:

Here you can see the weird lines appearing:

Looks like ScriptableRenderPass.Blit is no longer supported with 2023.x. I just tried upgrading to 2023.1.8 (URP-15.0.6) from 2022.3.7 (URP-14.0.8), and am getting the following error message starting on line 115 in the Execute method of URP_BlitRenderFeature/Blit.cs:

ScriptableRenderPass.Blit(...) is obsolete: 'Use RTHandles for source and destination'

ScriptableRenderer.cameraColorTarget, and RendererTargetHandle have been marked as deprecated as well, but aren't yet throwing an error.

Is there a way to apply the effect on top of everything, including a Canvas UI set to Overlay?

would you know how this can be used to render foreground (0.1 to 20 units) at normal resolution and background (20 unit to 100) at 1/16 resolution?