Git Product home page Git Product logo

Comments (5)

clintval avatar clintval commented on September 26, 2024

Dictionaries are ordered in Py3.6+ implicitly and became a language feature in 3.7.

Could your provide a sample sheet in which the keys are read from a file and then written in a different order?

from sample-sheet.

clintval avatar clintval commented on September 26, 2024

Oh nevermind! I understand your request. The code to change would effectively be here:

samples_header = RECOMMENDED_KEYS + sorted(other_keys)
writer.writerow(pad_iterable(samples_header, csv_width))

I've been meaning to fix #51 this week so I'll build this into my time. Thanks for the request! I think it's a great addition and will definitely help with running a checksum or diff on a sample sheet.

from sample-sheet.

reisingerf avatar reisingerf commented on September 26, 2024

Great, thanks!
I do have a second request. I will open a new issue though.

from sample-sheet.

clintval avatar clintval commented on September 26, 2024

Hi @reisingerf I spent some suiting this issue today! With the changes, I did break the API a little in order to support ordered case-insensitive key access within samples and sections.

Could you check out the project on master and let me know if it suits you?

Also I spun-up auto-documentation for this project which will help describe the API. I will also post change-logs and deprecations going forward (as I trend towards v1).

http://sample-sheet.readthedocs.io/

Eager to hear your thoughts. Thanks!

from sample-sheet.

reisingerf avatar reisingerf commented on September 26, 2024

I had a quick run with out current sample sheet and it looks good to me.
I like the additional warnings (especially since I can disable them, if required).

Thanks a lot for addressing this so quickly!

from sample-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.