assetic-php / assetic Goto Github PK

I have mrclay/minify component installed as well.

In class Assetic\Filter\JSMinFilter, JsMin is called like this:

public function filterDump(AssetInterface $asset)
    {
        $asset->setContent(\JSMin::minify($asset->getContent()));
    }

except that there is no root class JSMin declared in mrclay module, only class JSMin\JSMin exists.

so changing Assetic\Filter\JSMinFilter like this solve the issue

<?php namespace Assetic\Filter;

use Assetic\Contracts\Asset\AssetInterface;
use JSMin\JSMin;

/**
 * Filters assets through JsMin.
 *
 * All credit for the filter itself is mentioned in the file itself.
 *
 * @link https://raw.github.com/mrclay/minify/master/min/lib/JSMin.php
 * @author Brunoais <[email protected]>
 */
class JSMinFilter extends BaseFilter
{
    public function filterDump(AssetInterface $asset)
    {
        $asset->setContent(JSMin::minify($asset->getContent()));
    }
}

am i something wrong that I have to change this file in order to make it work ? Or did the class namespace and declaration from mrclay changed ?

Thank you in advance

Hey,

Good day.

Seems kriswallsmith assetic has been replaced by assetic-php. I have a custom LastModifiedStrategy which worked fine but now throws the error:

PHP Fatal error:  Interface 'Assetic\Factory\Worker\WorkerInterface' not found...

If I replace the Assetic\Factory\Worker\WorkerInterface with Assetic\Contracts\Factory\Worker\WorkerInterface instead, the new error is:

Argument 1 passed to AsseticBundle\Service::setCacheBusterStrategy() must be an instance of Assetic\Factory\Worker\WorkerInterface

Been trying to revert my composer file to a previous version, but can't seem to get kriswallsmith version installed again.

Any assistance would be much appreciated, thanks.

Regards.
Jarrett

The package has been abandoned, and hasn't had a release for 11 years. It was tested only with PHP 5.x.
https://packagist.org/packages/meenie/javascript-packer

Hi,

while updating a project to PHP 7.4, I had to upgrade the unmaintained kriswallsmith/assetic to assetic-php/assetic. In doing so, a section of our code stopped working because it uses the Assetic\Extension\Twig\TwigFormulaLoader class, which was removed by commit 4e42ff8, authored by @jaxwilko.

Do you have any insight as to why this was done so, instead of updating it to work with Twig 2.11 as the commit message implies? I haven't found any drop-in replacement for this class in the project's code, so I'm currently in the process of reimplementing it on our side as a quick fix, but if you know of a more solid solution I'd gladly take it.

Also of note is that the README.md file still mentions that class in the Twig section, so maybe this example should also be updated.

Thanks.

What the reason why CompilerJarFilter was removed from the 2.0 release?

Hi,

I'm getting this error when using filter CssMinFilter Do I need to install anything else?

Hi!

First, thx for your great work!

At the moment I'm trying to get the package connected to my symfony 5 project. But i'm too stupid to get the twig integration running.
Do you know a working example for this where I can have a look at?
Best,
Tim

We should add an SVG sanitization filter that leverages the enshrined/svg-sanitize library to sanitize SVG files from unwanted scripts and (optionally) remote sources.

Refs: https://github.com/wintercms/storm/pull/61/files

When css file contains an universel selector following a comment, with another comment far in file or comment in var, it is then considered as a opening comment .

With comment in var
In:

/*! Keep me */*{box-sizing: border-box;}.form{--ring-inset: var(--empty, /*!*/ /*!*/);border: 0;}

Expected:

/*! Keep me */*{box-sizing:border-box}.form{--ring-inset:var(--empty,/*!*/ /*!*/);border:0}

Output:

/*! Keep me * /*!*/);border:0}

With another comment
In:

/*! Keep me */*{box-sizing: border-box;}/* Remove me */.noborder{border: 0;}

Expected:

/*! Keep me */*{box-sizing:border-box}.noborder{border:0}

Output:

/*! Keep me *.noborder{border:0}

I encountered this bug when using Laravel Mix with TailwindCss.
In Mix cssNano.discardComments is true by default, so the css code is compacted, and the universal selector is then appended to the Tailwind retained comment:

@charset "UTF-8";
/*! tailwindcss v3.0.23 | MIT License | https://tailwindcss.com*/*,:after,:before{border:0 solid #e7e5e4;box-sizing:border-box} ...

The LessphpFilter does not provide an interface to the registerFunction method in lessc.inc.php, however the ScssphpFilter does provide an interface to this through \Assetic\Filter\ScssphpFilter::registerFunction. Is there a reason there isn't parity between these 2 filters? I'm happy to do a PR to add this in, if it's likely to be approved.

thanks!

The scss_compass class belongs to leafo/scssphp-compass (or one of its published forks).

This package was never released, is not maintained anymore (last commit in 2012) and is for leafo/scssphp, not scssphp/scssphp. The last point means that the code is broken in Assetic, as ScssphpFilter uses the class from scssphp/scssphp.

It'd be nice to be able to extend/enhance parts of the library instead of copy/paste to do so.

Would you be open to changing the privates to protected to allow easier extension?

Hi,

is it possible for you to provide this package for php 8.0 too? I'm not able to install it with the current composer settings.

Following error is shown:

• assetic/framework v2.0.0 requires php ^7.2 -> your php version (8.0.1) does not satisfy that requirement.

But in the composer.json the requirements should be met ("php": "^7.2|^8.0")?!

Thank you, Best Regards

ScssphpFilter::registerFunction only exposes arguments for the name and the callable.
But the ScssPhp API supports a third argument to configure the Sass signature (or signatures) of the function, and this parameter is not exposed in any way in Assetic.
Currently, this parameter is optional, with a different behavior when you don't have it or you have it. and the behavior without knowing the signature is not spec-compliant (as the compiler is expected to validate the signature). As such, the plan is to make that argument mandatory in 2.0 of scssphp. It would be great if Assetic could allow using this argument.

Note that we currently plan a refactoring in scssphp which will impact the implementation of custom functions, for which we plan to add a new (optional) argument in registerFunction to opt-in for the new behavior (which also won't allow omitting the signature). Once that argument appears, it might make sense to support it too (forcing the value to opt-in or opt-out in ScssphpFilter itself would defeat the purpose of the per-function opt-in)