Change property scopes to protected? about assetic HOT 5 CLOSED

for reference, in Symfony, we don't only ask for a list of functions/properties that are requested to become protected. We also ask for a clear use case justifying this (and then, we first evaluate whether there is a better solution for the problem, through decoration or a new extension point before considering allowing inheritance-based extension)

from assetic.

Thanks for the feedback! I reviewed what I was trying to do, and created a PR with what I was really trying to accomplish.

Basically I would like to get the name and asset object that the AssetReference is using.

from assetic.

@dlundgren Feel free to submit a PR with the functions you intend to convert to protected, and we'll take a look. I don't see any issue with your suggestion, but we'll need to take a look and ensure it doesn't break anything.

from assetic.

Note that switching to protected increases the maintenance cost, as any refactoring can then become a BC break a lot more easily (it is very hard to refactor a class using protected rather than private while maintaining BC, because this is about refactoring a class API and not refactoring internals anymore (and when everything is protected, the inheritance-based API is a lot more leaky than any public API).

from assetic.

@stof agreed. We'll just have to see what comes in and give it careful consideration on the benefit ratio between maintenance and flexibility.

from assetic.