Custom functions in ScssphpFilter are not exposing the full upstream API about assetic HOT 7 CLOSED

I won't be able to submit a PR for that. I haven't used Assetic since years, so I prefer spending my time on other open-source work. I opened this issue due to being a scssphp maintainer, and finding that the Assetic filter was not compatible with our planned changes (not declaring arguments is now deprecated since our 1.5.0 release), not due to being an Assetic user.

from assetic.

@LukeTowers I'm not going to have much time for the next 2 weeks but if nobody has looked by then I can pick it up :)

from assetic.

I can try take a look at it in the next couple of days.

from assetic.

@stof just seeing this one now too, are you able to submit a PR for this or link to more details?

from assetic.

See https://scssphp.github.io/scssphp/docs/extending/custom-functions.html for the doc about custom functions in scssphp.

Regarding the future argument to opt-in for a new signature for the callable, it is related to scssphp/scssphp#265 but there is not a lot of details about the registerFunction change yet in it (the idea is that we would have a new boolean argument added in the signature to opt-in)

from assetic.

Fair enough, thanks @stof! @jaxwilko or @bennothommo do either of you have time to look into this?

from assetic.

Was longer than a couple of days, but #25 should provide the additional argument from the upstream API. 😛

from assetic.