Get admon icons working about docgist HOT 11 CLOSED

👍

You definitely want to do this work based off of Asciidoctor 1.5.0.rc.2 or better since we load FontAwesome differently from how we did it in 0.1.4. Namely, we use FontAwesome 4.1 and the CSS classes are slightly different. Run it through Asciidoctor Ruby passing -a icons=font to see what output you need to port over.

from docgist.

I experimented a bit and it seems very easy to get the icons in. I just need asciidoctor.js built from 1.5.0.rc.2 -- for some reason I fail to build it.

And DocGist already uses FontAwesome 4.1 for the icons in the menu bar.

from docgist.

Excellent!

What's the failure building Asciidoctor.js? We definitely want to make sure that builds clean before 1.5.0 core is released.

from docgist.

That was my borked local environment. Switched to a different machine, everything went just fine. More to come ...

from docgist.

Oops, I was to fast on this one. The update it still in master, but I reverted it in gh-pages.
It really looked awesome on the pages where it worked.
No luck with this one though:
http://gist.asciidoctor.org/?ccd7210bd915da0f7713

Error
NoMethodError:
undefined method `[]' for nil

I'll see if I can dig into it.

from docgist.

@mojavelinux

It's about undefined attributes. I get the same error using the Ruby version.
Here's the trace:
https://gist.githubusercontent.com/nawroth/c00249bf5d51f42ce72e/raw/5f25097c1535b8b856933d3514baffc9f343eebf/trace

from docgist.

It's more complicated ... investigating.

from docgist.

This looks like a bug in core. Here's the problematic content:

[[repositories.create-instances.java-config]]
===== JavaConfig
The repository infrastructure can also be triggered using a store-specific `@Enable${store}Repositories` annotation on a JavaConfig class. For an introduction into Java-based configuration of the Spring container, see the reference documentation.footnote:[JavaConfig in the Spring reference documentation - link:$${spring-framework-docs}/beans.html#beans-java$$[]]

I made a change to passthrough handling recently...looks like something got borked. I'll get to the bottom of it. This likely has nothing to do with your change...so you may want to just move forward with it.

from docgist.

Wow, I really missed that scenario in my testing! Thanks for catching that before 1.5.0 made it out the door! I've resolved it upstream.

from docgist.

That's great news! I just narrowed it down to the actual problem as well ...

from docgist.

I'll continue here as soon as there's a new RC out.

from docgist.