Read attributes from the URL about docgist HOT 7 CLOSED

👍 I love this feature in the Chrome extension. I use it all the time.

from docgist.

I think you pointed me to the code over there already. It's such a low hanging fruit, I should just get it done.

from docgist.

@mojavelinux This reminds me ... should source-language affect plain literalblocks, which are not really source blocks?

from docgist.

@mojavelinux See http://gist.asciidoctor.org/?github-asciidoc%2Fasciidoc%2F%2Fdoc%2Fsource-highlight-filter.txt&source-language=python&source-highlighter=pygments#_source_code_paragraphs

I'm actually not sure why the language attribute in the document isn't picked up when the page is rendered without overrides: http://gist.asciidoctor.org/?github-asciidoc%2Fasciidoc%2F%2Fdoc%2Fsource-highlight-filter.txt#_source_code_paragraphs
But anyhow, locking source-language from the URL works fine.
If language is set as well, it will win. (expected?)

I added pygments as highlighter to see if the sanity check still worked.
(see the output in the console)

from docgist.

But anyhow, locking source-language from the URL works fine.
If language is set as well, it will win. (expected?)

I suppose so. language is the deprecated attribute and source-language is now preferred. We're missing a test in core to validate what happens if both are specified. I guess we could say it's a bit undefined atm.

from docgist.

should source-language affect plain literalblocks, which are not really source blocks?

It shouldn't, though we are planning a change in this area. See asciidoctor/asciidoctor#1117. Even then, if a block is marked as listing or literal it should not get source highlighting.

from docgist.

Ok, I'll leave the literal blocks out for now, as the HTML generated for the different variants is identical.
I tried to collect some variations of this here: http://gist.asciidoctor.org/?b60dad2c320ecbea4694

from docgist.