Comments (24)
To clarify, the version is 1.5.3-preview.2 (notice the hyphen). https://www.npmjs.com/package/asciidoctor.js
from docgist.
I'm on it.
from docgist.
There seems to be a difference in how attributes are handled. At least that's my guess because:
- Syntax highlighting doesn't kick in: http://nawroth.github.io/docgist/#_source_code_highlighting
imagesdir
isn't picked up for images: http://nawroth.github.io/docgist/?github-asciidoctor%2Fdocgist%2F%2Fgists%2Fimages.adoc
@Mogztter
from docgist.
from docgist.
Plese update here when there's a fix.
from docgist.
Just released a 1.5.3-preview.3
.
This version should β‘ this π
from docgist.
from docgist.
The dist folder wasn't updated!
from docgist.
from docgist.
Damn!
Yes manual releases are prone to error... we should definitely automate the
process! Automate all the things!!!
Le 8 nov. 2015 1:01 PM, "Dan Allen" [email protected] a Γ©crit :
That's definitely something we should automate.
β
Reply to this email directly or view it on GitHub
#21 (comment).
from docgist.
1.5.3-preview.4
is out!
from docgist.
I'm still seeing the same issue.
You can try it out at http://nawroth.github.io/docgist/
from docgist.
@nawroth With Opal 0.8.0 doc.attributes.map
is empty (for an unknown reason) and you must use doc.attributes.smap
instead. Or you can use doc.$attrs('name')
to stay out of Opal's "internal".
from docgist.
doc.attributes.smap
works. One difference I noticed is that running with parse_header_only=true
will only return attributes that are actually in the document header, while it previously didn't mind a blank line between title and document attributes.
So I fixed the examples to work with it, for example:
- http://nawroth.github.io/docgist/?github-nawroth%2Fdocgist%2F%2Fgists%2Fimages.adoc
- http://nawroth.github.io/docgist/?github-nawroth%2Fdocgist%2F%2Fgists%2Fcodemirror.adoc
from docgist.
One difference I noticed is that running with parse_header_only=true will only return attributes that are actually in the document header, while it previously didn't mind a blank line between title and document attributes.
I think this is related to asciidoctor/asciidoctor.js#95 (comment)
doc.attributes.smap works.
Yes but you should use Hash's public methods instead: https://github.com/opal/opal/blob/master/opal/corelib/hash.rb
smap
is an internal property and Opal can decide to modify it or remove it in future version π
from docgist.
@Mogztter I'll fix that, thanks for the links. The more important point is that 1.5.3 seems to work fine with DocGist now. π
from docgist.
Yeah, thanks for your great work π
from docgist.
Updated it to use $has_key?
and $fetch
.
Are there any unresolved issues with the previews or will 1.5.3 be out soon?
from docgist.
We're still discussing an "issue" on attributes
here and here but I think the behavior is the same in Asciidoctor core (Ruby) and Asciidoctor.js... Hopefully @mojavelinux will clear up our questions and give us the green light to proceed.
So 1.5.3
should be out pretty soon!
from docgist.
I couldn't find any more problems, so I pushed my changes + a lot around syntax highlighting to http://gist.asciidoctor.org/
Will do another update if there are any changes in the final 1.5.3
.
from docgist.
it previously didn't mind a blank line between title and document attributes.
We should be strict about not permitting blank lines in the header, IMO.
from docgist.
@mojavelinux Agreed.
from docgist.
That's great news that you got it all working. Obviously, we still need to improve the usability of the APIs around document-level attributes and locking attributes, but that's for 1.6.0. What's important is that we have some really nice (and clear) use cases to study now. As far as 1.5.3 is concerned, if we understand how to work with what is there, then we are ready for release.
from docgist.
Or better upgrade to https://github.com/asciidoctor/asciidoctor.js/releases/tag/v1.5.9
from docgist.
Related Issues (20)
- Absolute image paths on GitHub HOT 7
- Link to included document not working. HOT 9
- Get interdocument xrefs working HOT 2
- Support Bitbucket and GitLab HOT 5
- Read attributes from the URL HOT 7
- Render footer with document metadata HOT 1
- Support files in Google Drive HOT 1
- Support the stylesheet attribute HOT 2
- Get a short url for the current page
- Convert problem in Safari HOT 26
- Make boolean attributes a toggle button in the Attributes menu
- Allow organizing maintained docs
- Where are fp- links documents stored? HOT 1
- Support interactive checkbox
- Allow setting garbage collection schedule on submitting a new gist. HOT 1
- PROJECT_REQUIRES_IMPORT HOT 4
- Google will discontinue the goo.gl on March 30, 2019 HOT 3
- Edit feature is not working HOT 1
- Footnote syntax doesn't work according to Asciidoctor documentation? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docgist.