Comments (9)
This is a good suggestion. Based on the work with the images, it shouldn't be too hard to implement.
from docgist.
I think it's reasonable to assume we can get includes working (filed as #11). The link feature is really only intended to be used on GitHub where we have no authority to enable includes (so we needed to provide a concession in the interim).
from docgist.
Right, rewriting the links would just be a temporary fix until we get includes working. Getting those working is a larger piece of work though.
from docgist.
rewriting the links would just be a temporary fix until we get includes working.
Totally reasonable.
from docgist.
The URLs get quite crazy when browsing into folders, that should be fixed at some point.
from docgist.
Example: http://goo.gl/1pGe3B
from docgist.
Are you referring to recursive includes? If so, there is a parameter to guard against this. max-include-depth I think.
from docgist.
It doesn't resolve ../
etc in URLs, but just appends it which works but makes the URL very long, especially after some browsing. Example: http://gist.asciidoctor.org/?github-asciidoctor%2Fdocgist%2F%2Fgists%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes.adoc
I'm surprised it works!
from docgist.
Oh, I see what you mean. Actually, I'm not too surprised it works because inside of Asciidoctor we normalize paths like crazy. So once it reads in the path, it resolves it down to a simple path and then processes it...at least, I'm pretty sure about that.
from docgist.
Related Issues (20)
- Absolute image paths on GitHub HOT 7
- Get interdocument xrefs working HOT 2
- Support Bitbucket and GitLab HOT 5
- Upgrade to Asciidoctor.js 1.5.3 HOT 24
- Read attributes from the URL HOT 7
- Render footer with document metadata HOT 1
- Support files in Google Drive HOT 1
- Support the stylesheet attribute HOT 2
- Get a short url for the current page
- Convert problem in Safari HOT 26
- Make boolean attributes a toggle button in the Attributes menu
- Allow organizing maintained docs
- Where are fp- links documents stored? HOT 1
- Support interactive checkbox
- Allow setting garbage collection schedule on submitting a new gist. HOT 1
- PROJECT_REQUIRES_IMPORT HOT 4
- Google will discontinue the goo.gl on March 30, 2019 HOT 3
- Edit feature is not working HOT 1
- Footnote syntax doesn't work according to Asciidoctor documentation? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docgist.