Git Product home page Git Product logo

Comments (9)

nawroth avatar nawroth commented on July 1, 2024

This is a good suggestion. Based on the work with the images, it shouldn't be too hard to implement.

from docgist.

mojavelinux avatar mojavelinux commented on July 1, 2024

I think it's reasonable to assume we can get includes working (filed as #11). The link feature is really only intended to be used on GitHub where we have no authority to enable includes (so we needed to provide a concession in the interim).

from docgist.

nawroth avatar nawroth commented on July 1, 2024

Right, rewriting the links would just be a temporary fix until we get includes working. Getting those working is a larger piece of work though.

from docgist.

mojavelinux avatar mojavelinux commented on July 1, 2024

rewriting the links would just be a temporary fix until we get includes working.

Totally reasonable.

from docgist.

nawroth avatar nawroth commented on July 1, 2024

The URLs get quite crazy when browsing into folders, that should be fixed at some point.

from docgist.

nawroth avatar nawroth commented on July 1, 2024

Example: http://goo.gl/1pGe3B

from docgist.

mojavelinux avatar mojavelinux commented on July 1, 2024

Are you referring to recursive includes? If so, there is a parameter to guard against this. max-include-depth I think.

from docgist.

nawroth avatar nawroth commented on July 1, 2024

It doesn't resolve ../ etc in URLs, but just appends it which works but makes the URL very long, especially after some browsing. Example: http://gist.asciidoctor.org/?github-asciidoctor%2Fdocgist%2F%2Fgists%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes%2F..%2Fincludes.adoc
I'm surprised it works!

from docgist.

mojavelinux avatar mojavelinux commented on July 1, 2024

Oh, I see what you mean. Actually, I'm not too surprised it works because inside of Asciidoctor we normalize paths like crazy. So once it reads in the path, it resolves it down to a simple path and then processes it...at least, I'm pretty sure about that.

from docgist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.