Comments (9)
Right, we'd need to give Asciidoctor access to the gist fetchers somehow.
How about patching the include macro?
from docgist.
Patching the include macro is as straightforward as implementing an IncludeProcessor extension.
While there are some caveats with this extension point at the moment, it will work for 80% of the cases rather easily.
The main caveat is that a custom IncludeProcessor must handle all aspects of the include, which includes line and tag selection. I do plan to make that a concern that is handled by the core after invoking the IncludeProcessor#process method, but that's in the future.
from docgist.
As a side note, this is the extension point that will eventually allow includes to work on GitHub, assuming they entertain the idea.
from docgist.
What's the current state of the IncludeProcessor?
from docgist.
from docgist.
I realized that a document with many includes could use up the allowed rate limit on the GitHub API pretty fast. "For unauthenticated requests, the rate limit allows you to make up to 60 requests per hour." Could work for other hosts though.
from docgist.
We could use gh-pages
from docgist.
This is a major value proposition for DocGist since GitHub security is unwilling or unable to enable includes. DocGist provides an ideal workaround. The rate limit is just something we'll have to work through, but I don't think we should let it be a show stopper.
from docgist.
Since includes work in the Chrome extension, I'm not entirely sure I understand why we can't make it work the same way in DocGist. In theory, the Chrome extension and DocGist would be subject to the same rate limit problem, and that's never been a factor. cc: @Mogztter
from docgist.
Related Issues (20)
- Absolute image paths on GitHub HOT 7
- Link to included document not working. HOT 9
- Get interdocument xrefs working HOT 2
- Support Bitbucket and GitLab HOT 5
- Upgrade to Asciidoctor.js 1.5.3 HOT 24
- Read attributes from the URL HOT 7
- Render footer with document metadata HOT 1
- Support files in Google Drive HOT 1
- Support the stylesheet attribute HOT 2
- Get a short url for the current page
- Convert problem in Safari HOT 26
- Make boolean attributes a toggle button in the Attributes menu
- Allow organizing maintained docs
- Where are fp- links documents stored? HOT 1
- Support interactive checkbox
- Allow setting garbage collection schedule on submitting a new gist. HOT 1
- PROJECT_REQUIRES_IMPORT HOT 4
- Google will discontinue the goo.gl on March 30, 2019 HOT 3
- Edit feature is not working HOT 1
- Footnote syntax doesn't work according to Asciidoctor documentation? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docgist.