arty42 / poe-iteminfo Goto Github PK

delete, wrong repository

There is an issue looking for the price of a marble amulet : https://pathofexile.gamepedia.com/Marble_Amulet

it searches for the unique version(Bloodgrip Marble Amule), not the base item.

Even before I implemented the Item.hasImplicit and Item.Implicit variables ItemInfo was displaying the item's implicit on the tooltip. This seems to only work for enchantments and non-corruption only implicits. It's working for my unchanged corrupted Magnate Belt, but not for my changed Kaoms Heart, Daressos Defiance and Tabula Rasa. While my parsing works for Kaoms Heart etc, assigning the correct mod to Item.Implicit, it fails for Tabula.

ItemDataParts%ItemDataIndexImplicit% which should contain the corrupted implicit has Sockets: W-W-W-W-W-W instead.

I'm not sure when I'm looking into fixing this, therefore I wanted to leave this here.

i would love to see total res on the item info popup.

I'll leave this here as a note, maybe I'll implement it myself sometime, maybe someone will beat me to it.

Although I added an IsEssence check there is still no tooltip text for essences (stacksize, upgrades to/from, can be corrupted to/from).

This seems to happen for every unique item that have range values.
The file is properly read since the tooltip shows the range but it fails to show the original value.

Using ItemInfo script in pair with TradeMacro (iteminfo 2.5.06, trademacro 2.05).
Unfortunately I couldn't find any option that allow me to extend list of pseudo mods or configure it in any way. As a result I can see different global (hidden) mods and stats conversion, but I loose such things as total elemental res for example.
Is there any way you guys @aRTy42 and @Eruyome can improve this?

After updating from 3.0.3, my fps plummeted from about 100 to 30 in hideout, and even worse in maps. Also observed the game crashing on me more frequently. Tried the usual reboot, fresh install solutions, but reverted back to 3.0.3 which causes no issues for me.

im using the newest version there is and it dosn't work at all i press ctrl+c and nothing happens
running the newest version of ahk. and windows 10

I added a hotkey to allow a signal in alteration crafting.
Shift z will send a click to the server, wait, and then copy the item to clipboard. If the alteration signal is turned on, the item will be evaluated with the user pre-sets in AlterationCraftingSignalInput.txt to communicate whether a desired outcome was achieved.

It can't be pulled because aRTy42 branch has functionality changes based on SHIFT being depressed.
Shift is tied to mass-crafting as well as the filling of AffixLines tiers, which are used in evaluation.

This feature seems valuable, and the logic necessary exists in this project already. It could be expanded to chaos crafting as well.

Take a look at this screenshot. I can't tell where the issue is coming from. Standard win7 x64 w/ gtx1070
all scaling / zoom is off in os/gpu settings as far as i can tell.

PoE-TradeMacro#128 As descibed here the parsing fails in this case.

Loop, Parse, ItemDataNamePlate, `n, `r

This loop returns after finding "cage" in the second line of the item name plate assuming the item is a helmet without checking the third line were it would find "map". Not sure what the best solution to solve this would be, yet.

When starting this script - got an error like this: Call to nonexistent function
http://imgur.com/a/K7V2u

http://i.imgur.com/eiWdc1q.png
Regexp should be
"Monsters have \d+% chance to Avoid Elemental Ailments"
instead of
"Monsters have \d+% chance to Avoid Elemental Status Ailments"

Mostly in the tooltip section, i'm working on it.

I believe unique flasks need GetNegativeAffixOffset to increment NegativeAffixOffset once for the flask text and once for the unique flavour text.

I never liked using all those data files for affixes (tiers) and as far as I know there's no script to update/compile this data.

Maybe using this here is worth a shot https://github.com/brather1ng/RePoE, would require some work though, replacing all that file parsing code presently used. We could either directly use the uploaded data files there or use the same tools to generate this data from the GGPK, maybe further processing it.

I never tried touching all this parsing from the GGPK because I don't really know python and don't like it after trying to do some basic things here and there :p

I think it would be nice if in the search feature popup it would show (if any) who has duplicate posts and how many of them they have. This would be helpful for a quick way to tell if the prices are being fixed. That way we could easily figure out if we should check poe.trade for more information.

Subj

Should be "Gisale, Thought Theif"

Hi,

I cannot find the info for the meaning of CP (prefix) and CS (suffix).
With such mods, it seems that an item can have up to 9 mods !!!!
Can someone explain ?

example here :

Rarity: Rare
Foe Edge
Eye Gouger

Claw
Physical Damage: 39-103 (augmented)
Elemental Damage: 1-3 (augmented)
Critical Strike Chance: 7.74% (augmented)
Attacks per Second: 1.50
Weapon Range: 9

Requirements:
Level: 64
Dex: 113
Int: 113

Sockets: R G

Item Level: 77

+50 Life gained for each Enemy hit by Attacks

51% increased Physical Damage CP
7% increased Elemental Damage with Weapons P
Adds 1 to 3 Cold Damage P
23% increased Critical Strike Chance S
+6 Mana gained on Kill S
+78 to Accuracy Rating CP
10% increased Accuracy Rating CS
15% increased Light Radius CS

Just started playing again after 6 months and when I installed everything from scratch, poe item info makes the default windows sound when I press ctrl+c to look at the item. What the heck did I do wrong? I never remembered it making noise.

Also, what happened to being able to click on items and have them pulled up in the wiki or poe.trade? I vaguely remember being able to do something like ctrl+s and it would pull it on on poe.trade or the ctrl+w wiki right away.

I'm currently trying to resolve this myself, but wanted to report it here anyway since I'm not sure that I will resolve it and some discussion could help.

While working on PoE-TradeMacro I noticed that the variable ItemData.Affixes holds the implicit mod of Shavronnes Wrappings instead of the actual affixes we want. I compared it with Infernal Mantle where it works.

Manually incrementing (line 6420):
ItemDataIndexAffixes := ItemData.IndexLast - GetNegativeAffixOffset(Item)
by 1 solves it for Shavs, but breaks it for the other uniques.

Looking at both uniques item data I can't see any difference that could cause this though:

Rarity: Unique
Shavronne's Wrappings
Occultist's Vestment
--------
Quality: +20% (augmented)
Energy Shield: 447 (augmented)
--------
Requirements:
Level: 62
Int: 180
--------
Sockets: B-B-B-B-B G 
--------
Item Level: 67
--------
8% increased Spell Damage
--------
199% increased Energy Shield
10% faster start of Energy Shield Recharge
+34% to Lightning Resistance
Reflects 1 to 250 Lightning Damage to Melee Attackers
Chaos Damage does not bypass Energy Shield
--------
Shavronne's apparel became ever more extravagant
as her body and soul became ever more corrupted.

Rarity: Unique
Infernal Mantle
Occultist's Vestment
--------
Quality: +20% (augmented)
Energy Shield: 454 (augmented)
--------
Requirements:
Level: 62
Int: 180
--------
Sockets: B 
--------
Item Level: 62
--------
4% increased Spell Damage
--------
+1 to Level of Socketed Fire Gems
31% increased Fire Damage
100% increased Global Critical Strike Chance
204% increased Energy Shield
15% of Fire Damage Converted to Chaos Damage
100% increased Spell Damage taken when on Low Mana
--------
Despair hums, softly, deadly, in the bones of my enemies. 
Eyes will burn, and souls wither, as they bask in my radiance.

;How many ticks to wait before removing tooltip. 1 tick = 100ms. Example, 50 ticks = 5secends, 75 Ticks = 7.5Secends
ToolTipTimeoutTicks=150

found this cant change ?

See attached image, Shaped Jungle Valley (t6, level 73) upgrades to Arachnid Tomb. However iteminfo states it is level 68 and upgrades to beach(the unshaped map).

This happens with all shaped maps I have available to test with.

Hi, the advanced search is good when i first open the script. But after some uses (like 2-3 times) the windows just shrink and the affixes are not readable anymore Is this a problem with the script or something in my computer? Thanks.

(Hopefully) See image above:

The stack size uses spaces as the thousands separator and breaks the currency conversion code.
Sorry for not just issuing a pull request but the fix is to change:
StackSize := StackSizeParts1
to:
StackSize := StrReplace(StackSizeParts1," ")
on line 6042 (inside the first Else of ConvertCurrency(ItemName, ItemStats))

I have those boots with " x% chance to Avoid being Frozen " ( see attachment )

I couldn't find any infos about item mods like this one, It's only mentioned as a passive skill.

I was also wondering how the data text files ( in /data ) were generated, were those fetched from somewhere or hand made ?

Any resources I should know of ?

I could process the mod without the value range, but I have no clue if it's a prefix or suffix.

Any suggestions ?

"unexpected message or incorrect format"

autohotkey version 1.1.24.05

Howdy! I love the tool, thank you for writing and maintaining it.

Request: When I search on a currency, like an Exalted orb, it will show me people on poe.trade selling an exalt and how many chaos I have to pay. I'd like a checkbox that will also show beside it people buying exalts for chaos and how many chaos they're paying.

For each currency I search on, I'd like this.

Seeing both the bid and the ask gives me a much better idea of what the currency ratio is at the moment, or just how much I can sell my currency for.

Thanks.

that fixed it again ty ty ty , for all your time ,work an support cheers

error at line 148
as before it just don't run thank you for the work you did though I give up was a beautiful tool , sad to lose it..

Here is an item with 6 affixes (confirmed by vendor offering 1 Orb of Augmentation), detected as 5 affixes (4 + 1 hybrid):

From what I can tell it has:

• X% increased Armour prefix
• X% increased Armour, X% increased Stun and Block Recovery prefix
• X% increased Stun and Block Recovery suffix

but with these particular rolls it's impossible to determine that it's not only the 2 non-hybrid rolls.

Don't have any solution :( Just documenting it here since I could not find any existing issue on it.

I use the pause key for push-to-talk, I have it rebound to a custom G key on my keyboard. Unfortunately this causes this script to pause/unpause when I try to use push-to-talk. I've been commenting out the line where pause is captured by the script to avoid conflicts, but this has to be redone every time I relaunch the script.

It would be great if you could add a way to change this keybind or simply remove it.

A while ago I renamed this folder (TradeMacro) to lowercase, someone complained about it. Now I have it lowercase on my repo but it's still uppercase on this repo, that's really annoying when I want to merge ItemInfo to TradeMacro... Could you change this please?

http://stackoverflow.com/questions/11183788/in-a-git-repository-how-to-properly-rename-a-directory

I was using 1.1.4 without any issue and I just upgraded to 1.1.7.

^d tooltip doesn't contain any sell, and ^q opens a webpage with this message "The browser (or proxy) sent a request that this server could not understand."

Am I doing it wrong or is the 1.1.7 broken?

https://autohotkey.com/board/topic/29449-gdi-standard-library-145-by-tic/

UI example https://raw.githubusercontent.com/poeqic/qic/gh-pages/images/scr01.png

Should be possible to have differently colored lines, too. Not sure right now.

Random find, easy fix. I know the method is not used but it was still broken.

Code

line 9836 of POE-ItemInfo.ahk doesn't do anything (unreachable? probably my bad lol)
SendInput ^{sc02f}{Enter} ; sc021 = f sc02f = v

Narrow Highlight

Flasks:
Experimenter's Sulphur Flask of Iron Skin -> "Experimenter's Sulphur Flask" (should be "Sulphur Flask"?)
Experimenter's Quicksilver Flask -> "Experimenter's Quicksilver Flask" (should be "Quicksilver Flask"?)
Experimenter's Granite Flask -> ""

Broad Highlight

Flasks -> "Flask" also matches flask recovery items. Probably can't be helped?
Rustic Sash -> " Belt" also matches flasks but not rustic sash.
Prophecy orbs yield an empty result.
Dazzling Ashscale Talisman -> " Amulet" Doesn't match talisman items.

Boots:
Wrath Span Shagreen Boots -> "Evasion Rating:"
Domination Spur Conjurer Boots -> "Energy Shield:"

One of the nice features of D3planner is that it shows the "percentage of perfection" of an item; that is, how close to the absolute best possible roll for an affix the item has, expressed as a percentage.

For a PoE example, an iLvl 77 1H Axe (Flaring) can roll +phys damage od 20-27 to 41-49; 0% would be "20-41", 100% would be "27-49"; basically, how close to the maximum average damage is this affix within the tier.

Some things are trivial, such as "of Nourishment", which is fixed at +5 life on hit, so they would always be 100%. (Alternately: ignored in percentage calculations entirely. Either one works.)

It also shows the "overall" perfection: the average of the individual affix and implicit "perfection" percentages, so that something with an 80% +phys, and a 20% +light, would score an overall 50% on the perfection scale.

It's clearly not a substitute for actual judgment about the item: a low overall perfection score might still be way better for me than a higher overall perfection item that had lower scores on the things I cared about; if that concerns you, just presenting this additional data for each affix would certainly make it easier to see how good compared to possible this is.

It was brought to my attention that the currency ratios used by ItemInfo are different than those used by TradeMacro and that it would be nice to use Trademacro's rates instead. PoE-TradeMacro#188

So if I wanted to implement this I could add some global array for these values to ItemInfo and overwrite that by TradeMacro, but wouldn't it be nice to have those correct values for the standalone ItemInfo, too?

The simplest way would be to get those values from poe.ninjas API (I asked the developer /u/rasmuskl for permission for TradeMacro):
http://poe.ninja/api/Data/GetCurrencyOverview?league=Breach

This would introduce the problem that ItemInfo doesn't know the current league names, we could use TradeMacros code for this but that would only overcomplicate things. Adding the same dropdown list to the settings that I use for TradeMacro (standard|hardcore|tmpstandard|tmphardcore) and asking the poe.ninja dev if he could make this data available using those strings in addition to the actual names could work.

Then it's simply a matter of downloading this json data to variable with winhttp or to file with UrlDownloadToFile and to parse it so that it has the format ItemInfo is using:

Scroll of Wisdom|250:1
Portal Scroll|200:1
Armourer's Scrap|40:1

Currencyrates.txt should still be used as fallback. The download can be done once on script start or every 30min (or some other value), that's what I do for TradeMacro, too.

This functionality is probably not used by many but it would be greatly improved.

Rarity: Unique
Mjölner

Gavel

One Handed Mace
Physical Damage: 76-139 (augmented)
Critical Strike Chance: 5.00%

Attacks per Second: 1.15

Requirements:
Level: 60
Str: 412 (augmented) (unmet)

Int: 300 (augmented) (unmet)

Sockets: R

Item Level: 73

40% increased Stun Duration on Enemies

80% increased Physical Damage
Skills Chain +1 times
30% increased Lightning Damage with Weapons
+200 Strength Requirement
+300 Intelligence Requirement

30% chance to Cast Socketed Lightning Spells on Hit

Look the storm in the eye and you will have its respect.

on line 10515 of the POE-ItemInfo.ahk file, the API endpoint for currency rates is incorrect. I have changed locally and it seems to be working now, but I cannot commit my changes. Please update the master to have the following change:

Change line 10515:
FROM : http://poeninja.azureedge.net/api
TO : http://poe.ninja/api

The affixes granted by essences don't show up. Have tested with Essence of Delirium applied to a weapon and a ring.

Haven't looked into it, just making a note for now. Tested with latest TradeMacro code and also current ItemInfo master code.

Rarity: Rare
Vivid Stone
Viridian Jewel
--------
Item Level: 70
--------
3% additional Chance to receive a Critical Strike
--------
15% increased Physical Damage with Daggers
9% increased Chaos Damage
+10% to all Elemental Resistances
--------
Place into an allocated Jewel Socket on the Passive Skill Tree. Right click to remove from the Socket.
--------
Corrupted

After a random amount of time when trying to press ctrl + c on an item, nothing will happen. I have to right click the icon in the task bar, the menu opens after around 5 seconds and i press reload and it starts working again. When this happens the pause key will not work either it's like the whole script has stopped. When it is working normally right clicking the icon the menu comes up instantly.

http://stackoverflow.com/questions/21738647/change-date-of-git-tag-or-github-release-based-on-it

using git tag in the trademacro repo also lists iteminfo tags, the last releases 2.0.1 and 2.0.2 also have the wrong date... not sure about this stuff yet but maybe I will have to use some version prefix.

git show 2.0.1 tells me that was created 2015 by Bahnzo

or take a look at submodules to see if that can be an option... http://stackoverflow.com/questions/7813030/how-can-i-have-linked-dependencies-in-a-git-repo but this seems to be very complicated to use in this case.

should we decide to never use the v prefix for iteminfo and always use it for trademacro? does this solve all problems?

can't work in Other languages，
Is there any way to it works?

The ring in the attached screenshot has "+6% to all Elemental Resistances", however there's no line in the pseudo mods section that shows "+6% to Cold Resistance".

(The +6% IS correctly included in the pseudo mods for Fire and Lightning, and in the total.)