Comments (6)
I didn't like to look at a 3mb big json file, so I filtered the unique mods https://github.com/Eruyome/poe-filterItemAffixes/tree/master/output. I think that data is pretty nice.
from poe-iteminfo.
The current data files are not a very sophisticated solution, but they are easy to access, understand and edit. Since the affix brackets don't change that often (or ever), I don't really see the benefit of replacing everything.
Furthermore, the internal names of the mods seem slightly annoying to handle, with some having an extra underscore at the end for example. I'd bet that making sure that the script handles every mod correctly is not so straightforward and nice in the end. If we processed the data even further to bundle mod brackets together, we are getting close to what we have now.
So, basically: What do we actually gain?
from poe-iteminfo.
Data that doesn't have to be updated manually :p
I know this can be a lot of work, I'm just saying it's a possiblity. I'm probably a bit biased because I initially wanted to show the min/max values possible for rare items (advanced search), ignoring tiers. I mostly didn't do it yet because I didn't have the affix data and didn't want to use the files from the ItemInfo data folder ;-)
from poe-iteminfo.
Oh btw, those names (ids) can be translated easily https://raw.githubusercontent.com/brather1ng/RePoE/master/data/stat_translations.json. Just saying.
https://github.com/brather1ng/RePoE/blob/master/docs/mods.md
from poe-iteminfo.
It was not about translation, it is about correctly putting together what belongs together. For example having "ChanceToIgniteJewel_" with underscore but "ChanceToFreezeJewel" without or having "ColdDamagePercentEssence... 1, 2, 3, 4_, 5, 6_, 7". What currently sits in a single txt file is not grouped in those json files, two brackets of the same mod are stored structurally identical to a bracket of a different mod. Entries do have the key "group", but those are broader than our txt files. I see no trivial way to use the file as it is now nor a trivial way to further process it to our needs. Of course it is possible, but as I wrote above, the data barely changes, so manually updating is a non-issue.
from poe-iteminfo.
I'm not sure if you get any notification (issue reference) but it might interest you.
from poe-iteminfo.
Related Issues (20)
- 8mod map identified as 9mod HOT 3
- New Item Mods - unknown mod HOT 10
- Search Opal Ring with ilvl by default HOT 1
- SendCtrlC HOT 4
- Error : target label does not exist HOT 10
- to support French
- Don't remove clipboard contents HOT 1
- Highlight items gets old values HOT 1
- Error At Line 5 HOT 1
- Can't create control error HOT 2
- [Feature Request] Update MapList.txt for 3.6.0 HOT 1
- Tooltip timeout doesn't work
- is this normal? HOT 2
- Add hideout information to maps
- Display at fixed coordinates with MouseGetPos
- ItemInfo reports disscontinued stats from wiki (Queen's_Escape) HOT 2
- Currencyinfo from poe.ninja not available at startup HOT 1
- master
- No rare estimate HOT 1
- Script run but nothing work in game HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from poe-iteminfo.