Affix parsing failing for Shavronnes Wrappings (maybe more uniques) about poe-iteminfo HOT 8 CLOSED

GetNegativeAffixOffset() returns 2 instead of 1.

If (Item.IsFlask or Item.IsUnique or Item.IsTalisman) should only trigger this condition, but also triggers If (Item.IsCorrupted) because the flavor text contains "corrupted"

from poe-iteminfo.

You beat me to it by a few minutes. I found the wrong negativeOffset and was looking which part caused it.

from poe-iteminfo.

I can fix that, just needs something better than

 IfInString, ItemDataText, Corrupted
    {
        Item.IsCorrupted := True
    }

from poe-iteminfo.

The check for mirrored and effects are both horribly insecure aswell:

ItemIsMirrored(ItemDataText)
{
    Loop, Parse, ItemDataText, `n, `r
    {
        If (A_LoopField == "Mirrored")
        {
            return True
        }
    }
    return False
}

Item.HasEffect := (InStr(ItemData.PartsLast, "Has"))

Do you want to look into it or should I look for better solutions?

from poe-iteminfo.

I believe I fixed all checks, just trying to find a mirrored item to test that

from poe-iteminfo.

#14

Fixed and closed.

from poe-iteminfo.

I also noted that the ItemSubType is not reliable for uniques. The info script does not care, because the unique data displayed is based on the name, but for your script it might have consequences. For example the body armour "The Rat Cage" gets classified as a helmet because the name with "Cage" comes before the base type line "Sharkskin Tunic". If that is a problem, the solution is likely to narrow down the ItemDataNamePlate lines even more for uniques or items in general, before the whole regex match section starts.

from poe-iteminfo.

Ok, I will look into that. But for now we only care about the item name if it's a unique, since the name is, well, unique and we don't want other results. But also adding the subtype can't hurt.

from poe-iteminfo.